Re: [OpenJDK 2D-Dev] RFR: 8250855: Address reliance on default constructors in the Java 2D APIs

2020-09-17 Thread Peter Hull
Just for my curiosity, what issues can arise relying on default constructors? I couldn't find anything with google (apart from links back to these messages!) Thanks, Peter

Re: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to FontUtilities.java

2020-07-09 Thread Peter Hull
Probably not my place to comment, but, does it matter that it's doing unnecessary work evaluating the argument to logWarning et al, in the case where logging is not enabled? It only seems to be string concatenation and maybe would be optimised out anyway, I don't know. Peter On Thu, 9 Jul 2020 at

Re: [OpenJDK 2D-Dev] BufferedImage.getTileGridXOffset() not compliant with its specification?

2020-02-21 Thread Peter Hull
On Fri, 21 Feb 2020 at 13:44, Martin Desruisseaux wrote: > Implementation of getTileGridXOffset() and getTileGridXOffset() in > BufferedImage seems in contradiction with specification. The RenderedImage > specification said: Is this the same as bug 8166038?

Re: [OpenJDK 2D-Dev] Speed of drawPolyline on JDK11

2018-11-20 Thread Peter Hull
On Tue, Nov 20, 2018 at 8:28 AM Laurent Bourgès wrote: > Will you have time to review 2 small patchs on time ? If it would help for me to have a look, I am happy to do so. Pete

Re: [OpenJDK 2D-Dev] Speed of drawPolyline on JDK11

2018-10-12 Thread Peter Hull
This has been given a Java bug number now: JDK-8212124 https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8212124 I have been following the discussion here and I have a couple of workarounds to try, which is great. But, is there any more information you need from me? I'm always happy to

Re: [OpenJDK 2D-Dev] Speed of drawPolyline on JDK11

2018-10-11 Thread Peter Hull
Hi Laurent, Thanks for the detailed explanation. I quickly checked on the older Windows system and the Java 11 window was the same size as the Java 8 one, implying no scaling was going on (I guess just because it has a lower resolution monitor) - so that confirms your hypothesis. If I use

Re: [OpenJDK 2D-Dev] Speed of drawPolyline on JDK11

2018-10-11 Thread Peter Hull
I can answer part of that, but I can't get access to the older system just now. On Wed, Oct 10, 2018 at 4:41 PM Philip Race wrote: > In other words does > > -Dsun.java2d.uiScale=1.0 > > even change the physical size of the window on JDK 9/10/11 ? > Yes, because I can run the same jar under Java

Re: [OpenJDK 2D-Dev] Speed of drawPolyline on JDK11

2018-10-10 Thread Peter Hull
On Wed, Oct 10, 2018 at 1:21 PM Peter Hull wrote: > -Dsun.java2d.uiScale=1.0 > And this does make it fast again for me (paint time < 0.1sec)! Also I tried on an older system with "Intel HD Graphics 4600" and it did not have the slow down problem. So it seems to be quite specific to my system.

Re: [OpenJDK 2D-Dev] Speed of drawPolyline on JDK11

2018-10-10 Thread Peter Hull
On Wed, 10 Oct 2018 at 11:55 Laurent Bourgès wrote: > > Peter, > What is the corresponding bug ? > I don't know; I filled in the details and it said they would let me know the bug number if & when it was accepted. > > > I think it is -Djava2d.ui.scale=1.0 AFAIR. It's -Dsun.java2d.uiScale=1.0

Re: [OpenJDK 2D-Dev] Speed of drawPolyline on JDK11

2018-10-10 Thread Peter Hull
On Tue, Oct 9, 2018 at 3:52 PM Laurent Bourgès wrote: > Peter, what is your hardware & OS info ? It's an Intel core i7-8750H, 8GB RAM, intel UHD 630 graphics Windows 10 Pro 1803 build 17134.320 Note that Java 8 is still 'fast' so there must be some difference between 8 & 11. I saw that on Java

[OpenJDK 2D-Dev] Speed of drawPolyline on JDK11

2018-10-09 Thread Peter Hull
I posted this message first on Java Discuss and was asked to file a Java bug. It was also suggested I post it here for discussion. I've recently started using Java 11 and noticed that drawPolyline is much slower on my PC than it was on Java 8. Example, simplified code: @Override protected