On Mon, 23 Aug 2021 22:05:13 GMT, Daniel Gredler
wrote:
> During the recent JEP 381 removal of Solaris code, a few Solaris-specific
> constants and private methods were left behind in
> sun.font.TrueTypeGlyphMapper. This PR removes these unused odds and ends.
Completely out of scope by a
On Mon, 23 Aug 2021 22:05:13 GMT, Daniel Gredler
wrote:
> During the recent JEP 381 removal of Solaris code, a few Solaris-specific
> constants and private methods were left behind in
> sun.font.TrueTypeGlyphMapper. This PR removes these unused odds and ends.
I'm with Daniel on this one. I'd
On Mon, 23 Aug 2021 22:05:13 GMT, Daniel Gredler
wrote:
> During the recent JEP 381 removal of Solaris code, a few Solaris-specific
> constants and private methods were left behind in
> sun.font.TrueTypeGlyphMapper. This PR removes these unused odds and ends.
Marked as reviewed by prr
On Tue, 24 Aug 2021 21:13:57 GMT, Andrey Turbanov
wrote:
>> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to
>> use `ArrayList` if a thread-safe implementation is not needed. In
>> post-BiasedLocking times, this is gets worse, as every access is
>> synchronized.
On Thu, 15 Jul 2021 17:29:01 GMT, Nikita Gubarkov
wrote:
> It was implemented in JetBrains Runtime a year ago and was ported &
> refactored for this PR
> It includes:
> - Bitmap glyph loading via Freetype
> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or
>
On Thu, 15 Jul 2021 17:29:01 GMT, Nikita Gubarkov
wrote:
> It was implemented in JetBrains Runtime a year ago and was ported &
> refactored for this PR
> It includes:
> - Bitmap glyph loading via Freetype
> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or
>
On Sun, 15 Aug 2021 16:23:52 GMT, Phil Race wrote:
> This will fail regularly so problem list it.
This pull request has now been integrated.
Changeset: 6a5241c3
Author: Phil Race
URL:
https://git.openjdk.java.net/jdk/commit/6a5241c3adfd3ba886e469156dea56ed5b9673ff
Stats: 1 l
This will fail regularly so problem list it.
-
Commit messages:
- 8272491: Problem list
javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java on macos
Changes: https://git.openjdk.java.net/jdk/pull/5119/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5119=00
Issue:
On Thu, 12 Aug 2021 21:13:04 GMT, Phil Race wrote:
> passes
Looks good. I tried the test as headless and headful which happens to then
exercise a broader set of distros than only one or the other the way our
systems are set up.
-
PR: https://git.openjdk.java.net/jdk/pull/4572
On Fri, 13 Aug 2021 12:27:51 GMT, Maxim Kartashev
wrote:
>> Added an `ExceptionCheck()` followed by `ExceptionDescribe()` and
>> `ExceptionClear()` immediately after the Java calls made from the callback
>> function `ReadTTFontFileFunc()` in `freetypeScaler.c`.
>>
>> The exception(s) need
On Mon, 19 Jul 2021 20:50:14 GMT, Phil Race wrote:
> Applet support was removed already but the .html file was left as well as
> docs on applet issues
> and a parameter only relevant to applets.
This pull request has now been integrated.
Changeset: 0af645aa
Author:Phil
On Fri, 13 Aug 2021 12:29:06 GMT, Maxim Kartashev
wrote:
>> oh you are getting metrics for a JFrame ? That's not going to exercise any
>> new font code so is pointless except to make it so the test has to be
>> headful.
>
> But `getFontMetrics()` is the primary "entry point" that generated
On Thu, 12 Aug 2021 21:58:07 GMT, Phil Race wrote:
>> Maxim Kartashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Addressed PR comments
>>
>> 1. Added CHECK_NULL() to awt_Component.cpp
On Mon, 19 Jul 2021 09:38:27 GMT, Maxim Kartashev
wrote:
>> Added an `ExceptionCheck()` followed by `ExceptionDescribe()` and
>> `ExceptionClear()` immediately after the Java calls made from the callback
>> function `ReadTTFontFileFunc()` in `freetypeScaler.c`.
>>
>> The exception(s) need
On Mon, 19 Jul 2021 09:38:27 GMT, Maxim Kartashev
wrote:
>> Added an `ExceptionCheck()` followed by `ExceptionDescribe()` and
>> `ExceptionClear()` immediately after the Java calls made from the callback
>> function `ReadTTFontFileFunc()` in `freetypeScaler.c`.
>>
>> The exception(s) need
On Wed, 21 Jul 2021 15:45:55 GMT, Alexander Scherbatiy
wrote:
> The issue is reproduced on macOS Big Sur 11.0.1 with jdk 16.0.1+9.
>
> Create a native macOS app from the Hello.java file, sign and run it in
> sandbox:
>
> import javax.print.*;
> import javax.swing.*;
>
> public class Hello {
> Applet support was removed already but the .html file was left as well as
> docs on applet issues
> and a parameter only relevant to applets.
Phil Race has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated change
On Wed, 21 Jul 2021 06:19:13 GMT, Sergey Bylokhov wrote:
> Probably we can delete the SwingSet2.html as well?
Yes, there's a separate bug for that which I'll be getting around to.
-
PR: https://git.openjdk.java.net/jdk/pull/4831
On Thu, 22 Jul 2021 05:04:55 GMT, Prasanta Sadhukhan
wrote:
>> Applet support was removed already but the .html file was left as well as
>> docs on applet issues
>> and a parameter only relevant to applets.
>
> src/demo/share/jfc/Font2DTest/Font2DTest.java line 272:
>
>> 270:
On Wed, 11 Aug 2021 17:58:04 GMT, Severin Gehwolf wrote:
> Please review this simple build fix to correct the type done in JDK-8255790.
> After the patch correct external library is added to the `libfontmanager.so`
> link command when building with `--with-harfbuzz=system`.
>
> Thoughts?
On Sun, 4 Jul 2021 20:42:41 GMT, Andrey Turbanov
wrote:
> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to
> use `ArrayList` if a thread-safe implementation is not needed. In
> post-BiasedLocking times, this is gets worse, as every access is synchronized.
> I
On Tue, 6 Jul 2021 11:32:18 GMT, Сергей Цыпанов
wrote:
>> It's not a public API. As I see from other PR/commits changing
>> package-private methods shouldn't be a problem.
>
> Even non-public method can be called via reflection, so I'd be cautios about
> changing return type
Apps should not
On Sat, 7 Aug 2021 07:57:22 GMT, Sergey Bylokhov wrote:
> I have started the investigation of this code after this comment:
> https://github.com/openjdk/jdk/pull/2957#discussion_r592988443
>
> We have a suspicious synchronized keyword on the "setTagData" method. This
> method modified the
On Tue, 20 Jul 2021 19:34:30 GMT, Phil Race wrote:
> These fields
> - have not been used by the implementation since JDK8,
> - are not supposed to be used by applications,
> - have been deprecated for removal since JDK 9
> - are non-standard, JDK not Java, classes
>
On Wed, 21 Jul 2021 07:19:02 GMT, Sergey Bylokhov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8268824: Remove unused jdk.accessibility APIs deprecated for removal in
>> JDK 9
&
asses : just those
> implementing ATs
>
>
> The CSR for this is https://bugs.openjdk.java.net/browse/JDK-8270918
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8268824: Remove unused jdk.accessibility APIs deprecated for removal in
On Tue, 20 Jul 2021 06:25:22 GMT, Jayathirth D V wrote:
> We are incorrectly passing source offset to ImageInputStream.readFully()
> which is getting used on destination buffer. streamPos maintained in each
> implementation of stream maintain's appropriate source offset while reading
> the
On Wed, 21 Jul 2021 04:19:03 GMT, Prasanta Sadhukhan
wrote:
>> This test fails to follow the test instruction which says ""On Top" print
>> dialogs should stay behind the "Owner Window"
>> but it seems to be the behaviour right from jdk11b18 where DialogOwner class
>> and this test was
On Wed, 21 Jul 2021 04:22:05 GMT, Sergey Bylokhov wrote:
> Is it possible to create a testcase for this fix? Probably this regression
> should be fixed in jdk17?
FWIW the fixer had already written :
"Also to hit this code we need stream/file with at-least 1MB of IFD data,
that's why there is
On Fri, 16 Jul 2021 21:39:56 GMT, Vest
wrote:
>> This is the last part of Post JEP 411 refactoring that makes
>> `@SuppressWarnings("removal")` more fine grained. This fix deals with all
>> client libs annotations that cover more than 10K bytes of code.
>
>
On Fri, 16 Jul 2021 20:52:08 GMT, Weijun Wang wrote:
> This is the last part of Post JEP 411 refactoring that makes
> `@SuppressWarnings("removal")` more fine grained. This fix deals with all
> client libs annotations that cover more than 10K bytes of code.
On Wed, 23 Jun 2021 09:19:16 GMT, Maxim Kartashev
wrote:
> Added an `ExceptionCheck()` followed by `ExceptionDescribe()` and
> `ExceptionClear()` immediately after the Java calls made from the callback
> function `ReadTTFontFileFunc()` in `freetypeScaler.c`.
>
> The exception(s) need to be
On Fri, 23 Apr 2021 09:45:45 GMT, Toshio Nakamura wrote:
>> As far as I understand it is not directly related to the JTable and the bug
>> is reproduced if some specific font is used when any text is printed? Did
>> you check why the CTextPipe does not support it directly? It looks like the
On Fri, 11 Jun 2021 17:06:24 GMT, Anton Litvinov wrote:
>> Hello,
>>
>> Could you please review the following fix for the bug specific to macOS. The
>> bug consists in the fact that if the method
>> "java.awt.print.Printable.print(Graphics, PageFormat, int)" throws
>>
On Fri, 21 May 2021 20:16:41 GMT, Anton Litvinov wrote:
>> Hello,
>>
>> Could you please review the following fix for the bug specific to macOS. The
>> bug consists in the fact that if the method
>> "java.awt.print.Printable.print(Graphics, PageFormat, int)" throws
>>
On Mon, 31 May 2021 12:21:59 GMT, Anton Litvinov wrote:
>> test/jdk/java/awt/print/PrinterJob/ExceptionFromPrintableIsIgnoredTest.java
>> line 32:
>>
>>> 30:@run main/manual ExceptionFromPrintableIsIgnoredTest MAIN RE
>>> 31:@run main/manual ExceptionFromPrintableIsIgnoredTest EDT PE
On Tue, 8 Jun 2021 09:34:38 GMT, Ajit Ghaisas wrote:
>> test/jdk/java/awt/Graphics/DrawOvalTest.java line 26:
>>
>>> 24: /**
>>> 25: * @test
>>> 26: * @key headful
>>
>> I feel there's nop need to have headful tag for this test as there is no
>> frame being made visible, all rendering are
On Mon, 7 Jun 2021 12:03:35 GMT, Ajit Ghaisas wrote:
>> This PR fixes an issue exclusively seen on Apple M1 systems when SwingSet2
>> demo is run with uiScale=1.0.
>>
>> **Issue :**
>> SwingSet2 Demo - As reported in JBS description
>> J2DDemo - As reported in a comment on JBS
>>
>> **Root
On Mon, 7 Jun 2021 10:39:26 GMT, Alexey Ushakov wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLTexurePool.m
>> line 328:
>>
>>> 326: if (_maxPoolMemory < MAX_POOL_MEMORY) {
>>> 327: _maxPoolMemory = MAX_POOL_MEMORY;
>>> 328: }
>>
>> The Apple 5K retina
On Mon, 7 Jun 2021 15:12:44 GMT, Alexey Ushakov wrote:
>> Used MTLDevice recommendedMaxWorkingSetSize property for optimal size of the
>> texture pool
>
> Alexey Ushakov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8261549: Adjust
On Tue, 1 Jun 2021 09:20:07 GMT, Alexey Ushakov wrote:
> Used MTLDevice recommendedMaxWorkingSetSize property for optimal size of the
> texture pool
src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLTexurePool.m line
328:
> 326: if (_maxPoolMemory < MAX_POOL_MEMORY) {
> 327:
On Fri, 21 May 2021 20:16:41 GMT, Anton Litvinov wrote:
>> Hello,
>>
>> Could you please review the following fix for the bug specific to macOS. The
>> bug consists in the fact that if the method
>> "java.awt.print.Printable.print(Graphics, PageFormat, int)" throws
>>
On Fri, 21 May 2021 20:37:30 GMT, Weijun Wang wrote:
>> The code change refactors classes that have a `SuppressWarnings("removal")`
>> annotation that covers more than 50KB of code. The big annotation is often
>> quite faraway from the actual deprecated API usage it is suppressing, and
>>
On Fri, 28 May 2021 02:50:55 GMT, Weijun Wang wrote:
>> src/java.desktop/share/classes/java/awt/Component.java line 630:
>>
>>> 628: }
>>> 629:
>>> 630: @SuppressWarnings("removal")
>>
>> I'm confused. I thought the reason this wasn't done in the JEP
>> implementation PR is
On Fri, 21 May 2021 20:37:30 GMT, Weijun Wang wrote:
>> The code change refactors classes that have a `SuppressWarnings("removal")`
>> annotation that covers more than 50KB of code. The big annotation is often
>> quite faraway from the actual deprecated API usage it is suppressing, and
>>
On Mon, 24 May 2021 13:53:34 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>>
On Wed, 26 May 2021 21:37:44 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java line 77:
>>
>>> 75: int[] sizes = new int[] {16, 32, 48, 64, 128};
>>> 76: for (int size : sizes) {
>>> 77: ImageIcon icon = (ImageIcon)
On Wed, 26 May 2021 16:52:38 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Fixed small errors
>Adjustments in the test
> - Grammar fix in
On Wed, 26 May 2021 15:15:42 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> null file now properly causes IllegalArgumentException
>> Small fixed in JavaDoc
>
>
On Tue, 25 May 2021 23:36:43 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> null file now properly causes IllegalArgumentException
> Small fixed
On Tue, 25 May 2021 22:01:36 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Changed API to support non-square icons and updated documentation
>
On Fri, 21 May 2021 21:41:44 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Chenged implementation specification based on CSR review
> > if the
On Thu, 20 May 2021 22:25:05 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Specification of getSystemIcon reworded to get rid of the non-public
>
On Wed, 19 May 2021 13:47:53 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>>
On Thu, 20 May 2021 22:25:05 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Specification of getSystemIcon reworded to get rid of the non-public
>
On Tue, 18 May 2021 21:44:43 GMT, Weijun Wang wrote:
>> Please review the test changes for [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> With JEP 411 and the default value of `-Djava.security.manager` becoming
>> `disallow`, tests calling `System.setSecurityManager()` need
>>
On Thu, 20 May 2021 07:06:00 GMT, Alan Bateman wrote:
>> The JEP isn't PTT for 17 so there's plenty of time isn't there ?
>
> There are 827 files in this patch. Phil is right that adding SW at the class
> level is introducing technical debt but if addressing that requires
> refactoring and
On Tue, 18 May 2021 15:55:09 GMT, Phil Race wrote:
> See the bug report for lots of explanation.
> The short version (not that short) is that Swing adds a new line char to
> editable TextComponents
> It used to work because harfbuzz asked CoreText which mapped it to an
> invisi
On Thu, 20 May 2021 19:22:50 GMT, Alexander Zuev wrote:
>> But it is still part of the specification unlike implnote/apinote, and we
>> cannot use non-public classes there, since other JavaSE implementations may
>> not have this class. see discussion on the link above.
>
>> But it is still
On Tue, 18 May 2021 19:53:36 GMT, Sergey Bylokhov wrote:
>> See the bug report for lots of explanation.
>> The short version (not that short) is that Swing adds a new line char to
>> editable TextComponents
>> It used to work because harfbuzz asked CoreText which mapped it to an
>> invisible
On Thu, 20 May 2021 04:05:23 GMT, Phil Race wrote:
>> By converting JDK-8267432 to a bug, there is an extra benefit that we can
>> fix it after RDP. So I'll convert it now.
>
> That is unfortunate, but nonetheless I think required to be done.
> We have acknowledeged
On Thu, 20 May 2021 02:09:57 GMT, Weijun Wang wrote:
>> I can make it a bug.
>>
>> I don't want to do it here is because it involves indefinite amount of
>> manual work and we will see everyone having their preferences. The more time
>> we spend on this PR the more likely there will be merge
On Wed, 19 May 2021 22:14:20 GMT, Weijun Wang wrote:
>> I don't think it is a separate P4 enhancement (?) that someone will (maybe)
>> do next release.
>> I think it should all be taken care of as part of this proposed change.
>
> I just made it P3 (P4 was the default value), and I will target
On Wed, 19 May 2021 21:53:35 GMT, Weijun Wang wrote:
>> That's a sad limitation of the annotation stuff then, but I don't think that
>> it is insurmountable.
>> You can define a static private method to contain this and call it from the
>> static initializer block.
>> Much better than applying
On Fri, 14 May 2021 18:37:46 GMT, Anton Litvinov wrote:
> Hello,
>
> Could you please review the following fix for the bug specific to macOS. The
> bug consists in the fact that if the method
> "java.awt.print.Printable.print(Graphics, PageFormat, int)" throws
>
On Wed, 19 May 2021 18:38:39 GMT, Weijun Wang wrote:
>> src/java.desktop/share/classes/java/awt/Component.java line 217:
>>
>>> 215: * @author Sami Shaio
>>> 216: */
>>> 217: @SuppressWarnings("removal")
>>
>> Why is this placed on the *entire class* ??
>> This class is 10535 lines long
On Wed, 19 May 2021 13:47:53 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>>
On Wed, 19 May 2021 13:47:53 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>>
On Wed, 19 May 2021 13:47:53 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>>
See the bug report for lots of explanation.
The short version (not that short) is that Swing adds a new line char to
editable TextComponents
It used to work because harfbuzz asked CoreText which mapped it to an invisible
glyph
Now harfbuzz does its own processing of AAT fonts it is different.
On Fri, 7 May 2021 08:02:36 GMT, Dmitry Batrak wrote:
>> This is the implementation used by JetBrains Runtime for the last 4 years,
>> after some cleanup, and with one problem,
>> found while preparing the pull request, fixed.
>> Even though typical scenarios for a UI application should be
On Thu, 22 Apr 2021 09:21:20 GMT, Toshio Nakamura wrote:
> Hi,
>
> Could you review the fix?
> When non-English characters were printed from JTable on MacOS,
> CTextPipe.doDrawGlyphs was called by OSXSurfaceData.drawGlyphs. However,
> CTextPipe seems not support glyph with slot number of
On Fri, 19 Mar 2021 13:48:12 GMT, Dmitry Batrak wrote:
>> This is the implementation used by JetBrains Runtime for the last 4 years,
>> after some cleanup, and with one problem,
>> found while preparing the pull request, fixed.
>> Even though typical scenarios for a UI application should be
On Fri, 12 Mar 2021 07:22:26 GMT, Aleksey Shipilev wrote:
>> SonarCloud reports multiple incorrect double-checked locking cases in
>> `sun.java2d.CRenderer`. For example:
>>
>>
>> Arc2D arcToShape;
>>
>> ...
>> if (arcToShape == null) {
>> synchronized (this)
On Thu, 15 Apr 2021 14:42:55 GMT, Denis Konoplev wrote:
> I've removed MaxTextureSize and replaced its usages with
> MTL_GPU_FAMILY_MAC_TXT_SIZE
Marked as reviewed by prr (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3519
On Wed, 5 May 2021 07:37:23 GMT, Jayathirth D V wrote:
>> We have many if else conditions to select OpenGL/Metal pipeline objects.
>> Apart from initialization phase we should not fetch these objects everytime
>> checking whether we are using OpenGL/Metal pipeline.
>
> Jayathirth D V has
On Thu, 6 May 2021 06:58:16 GMT, Thomas Stuefe wrote:
>> Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS
>> issue.
>>
>> I fixed the issue in the harfbuzz sources, but I am not sure of the policy
>> here. Do we modify the harfbuzz sources or leave them untouched?
On Tue, 4 May 2021 14:24:22 GMT, Phil Race wrote:
> Upgrades OpenGL header files to the latest Mesa project ones.
> Build+test looks fine.
This pull request has now been integrated.
Changeset: 138d573c
Author: Phil Race
URL:
https://git.openjdk.java.net/jdk/
On Sat, 1 May 2021 00:19:27 GMT, Yasumasa Suenaga wrote:
>> We can see following compiler warnings in imageioJPEG.c on GCC 11.
>
> Yasumasa Suenaga has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Disable -Warray-bounds in makefile
Marked
On Fri, 30 Apr 2021 20:07:53 GMT, Phil Race wrote:
> Upgrade to harfbuzz 2.8
This pull request has now been integrated.
Changeset: 80323b7f
Author: Phil Race
URL:
https://git.openjdk.java.net/jdk/commit/80323b7f66541e24177d02cc668a2eb9267962b9
Stats: 13120 lines in 123 fi
On Mon, 3 May 2021 23:10:13 GMT, Phil Race wrote:
> This is just clean up. The value will be zero by default and explicitly (if
> you follow along far enough) zero.
> The no-args constructor just merges physical fonts and those are set up with
> zero anyway
This pull request
On Tue, 4 May 2021 11:02:40 GMT, Jayathirth D V wrote:
> We have many if else conditions to select OpenGL/Metal pipeline objects.
> Apart from initialization phase we should not fetch these objects everytime
> checking whether we are using OpenGL/Metal pipeline.
LGTM. Is there anything not
Upgrades OpenGL header files to the latest Mesa project ones.
Build+test looks fine.
-
Commit messages:
- 8262392: Update Mesa 3-D Headers to version 21.0.3
Changes: https://git.openjdk.java.net/jdk/pull/3854/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3854=00
This is just clean up. The value will be zero by default and explicitly (if you
follow along far enough) zero.
The no-args constructor just merges physical fonts and those are set up with
zero anyway
-
Commit messages:
- 8263124: Missed initialization of baselineY in
On Sat, 1 May 2021 01:42:04 GMT, Sergey Bylokhov wrote:
> I assume the build using bundled lib is fine on all our platforms.
Yes.
-
PR: https://git.openjdk.java.net/jdk/pull/3826
Upgrade to harfbuzz 2.8
-
Commit messages:
- 8261169: Upgrade HarfBuzz to the latest 2.8.0
Changes: https://git.openjdk.java.net/jdk/pull/3826/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3826=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8261169
Stats: 13120
On Fri, 30 Apr 2021 19:52:17 GMT, Daniel D. Daugherty
wrote:
>> A trivial fix to ProblemList
>> java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on
>> linux-x64.
>
> Daniel D. Daugherty has updated the pull request incrementally with one
> additional commit since the
On Fri, 30 Apr 2021 19:49:17 GMT, Daniel D. Daugherty
wrote:
>> A trivial fix to ProblemList
>> java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on
>> linux-x64.
>
> Daniel D. Daugherty has updated the pull request incrementally with one
> additional commit since the
On Fri, 30 Apr 2021 19:32:43 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on
> linux-x64.
Please make it generic
-
PR: https://git.openjdk.java.net/jdk/pull/3824
On Fri, 30 Apr 2021 00:18:15 GMT, Yasumasa Suenaga wrote:
>> src/java.desktop/share/native/libjavajpeg/imageioJPEG.c line 673:
>>
>>> 671: if (info->is_decompressor) {
>>> 672: j_decompress_ptr dinfo = (j_decompress_ptr) info;
>>> 673: #ifdef __GNUC__
>>
>> I know how these
On Thu, 29 Apr 2021 07:10:33 GMT, Yasumasa Suenaga wrote:
> We can see following compiler warnings in imageioJPEG.c on GCC 11.
src/java.desktop/share/native/libjavajpeg/imageioJPEG.c line 673:
> 671: if (info->is_decompressor) {
> 672: j_decompress_ptr dinfo =
On Thu, 29 Apr 2021 07:57:17 GMT, Prasanta Sadhukhan
wrote:
> It seems the newly deproblemlisted test
> DrawRotatedStringUsingRotatedFont.java which is paasing in windows,linux-x64
> and macos-x64 is failing in newly added linux-aarch64 systems.
> Problemlisting the test for now as it is font
On Wed, 28 Apr 2021 13:55:28 GMT, Alexander Scherbatiy
wrote:
>> PDFBox 1.8 uses
>> [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352)
>> method with scaled
On Thu, 22 Apr 2021 15:13:45 GMT, Alexander Scherbatiy
wrote:
> PDFBox 1.8 uses
> [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352)
> method with scaled
On Thu, 22 Apr 2021 15:13:45 GMT, Alexander Scherbatiy
wrote:
> PDFBox 1.8 uses
> [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352)
> method with scaled
On Fri, 16 Apr 2021 05:57:13 GMT, Ajit Ghaisas wrote:
> This PR makes Metal as the default Java2D rendering pipeline for macOS.
>
> Note : from JBS description :
> The plan of record has always been that for JDK 17 the new Metal pipeline
> will be OFF by default and must be explicitly enabled
On Fri, 2 Apr 2021 23:06:43 GMT, Sergey Bylokhov wrote:
>> - The hand-crafted methods for addition and multiplication are replaced by
>> the "Math" versions.
>> - Cleanup: the usage of do/while(false) is removed
>
> The nice PR number: !
I don't understand the exception handling here.
On Fri, 26 Mar 2021 19:53:44 GMT, Phil Race wrote:
> https://bugs.openjdk.java.net/browse/JDK-8255800 could have been a one line
> spec clean up but
> it didn't take a lot of looking to realize there were many more
> inconsistencies between spec and implementation.
> I've spen
gt; JCK conformance tests still pass so they must not test those conditions.
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8255800: Raster creation methods need some specification clean up
-
Changes:
- all: https://git.ope
On Fri, 2 Apr 2021 21:03:30 GMT, Sergey Bylokhov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8255800: Raster creation methods need some specification clean up
>
> Marked as reviewed
1 - 100 of 1461 matches
Mail list logo
