Re: [OpenJDK 2D-Dev] RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

2020-09-17 Thread Stuart Marks
On Fri, 11 Sep 2020 15:17:58 GMT, Bradford Wetmore wrote: >> Ok, sorry for the distraction. > > Our local Santuario maintainer says: > > In general, changes to Apache Santuario should also be made at Apache so we > stay in sync. Hi @doom369, I hope we didn't end up wasting too much of your tim

Re: [OpenJDK 2D-Dev] [9] request for review: 8068749: Restrict javax.imageio.spi.ServiceRegistry to ImageIO types

2015-08-12 Thread Stuart Marks
Hi all, I still need a second reviewer for this change. Thanks. s'marks On 8/3/15 1:49 PM, Phil Race wrote: CCC is approved. So I will give this a "+1" .. you just need one other reviewer (if you did not get that already) and you can push. -phil. On 07/27/2015 07:10 PM, Stu

[OpenJDK 2D-Dev] [9] request for review: 8068749: Restrict javax.imageio.spi.ServiceRegistry to ImageIO types

2015-07-27 Thread Stuart Marks
Hi all, Please review this following code and API change: Bug: https://bugs.openjdk.java.net/browse/JDK-8068749 Webrev: http://cr.openjdk.java.net/~smarks/reviews/8068749/webrev.0/ The change is to be pushed into the jdk9/client forest. The background is that this is a "prepar

Re: [OpenJDK 2D-Dev] Request for review: 7196571, 7196572, 7196573: javac warnings cleanup from Adopt OpenJDK bugathon

2012-09-12 Thread Stuart Marks
On 9/11/12 1:41 PM, Martijn Verburg wrote: * By contrast lines 1035 and 1115 here are now much, much > 80 chars http://cr.openjdk.java.net/~art/Bugathon-2012/webrev.imageio/src/share/classes/javax/imageio/ImageIO.java.sdiff.html Also for both of these cases, you added .asSubClass(..). Now when I

Re: [OpenJDK 2D-Dev] Warning Fixes from LJC Hack Session

2012-02-06 Thread Stuart Marks
Michael, Thanks for splitting up the patches and revising them in response to the review comments. I'm not yet entirely sure how to proceed with pushing these changes. I think Chris assumed that I would push these changes. Since these are in awt, printing, and beans, the changes might need t