Re: [OpenJDK 2D-Dev] [10] RFR JDK-8191814: Marlin rasterizer spends time computing geometry for stroked segments that do not intersect the clip

Hi, I pushed in jdk forrest: http://hg.openjdk.java.net/jdk/client/rev/fd7fbc929001 Thanks for your reviews, Phil & Sergey ! Laurent 2017-12-07 20:43 GMT+01:00 Sergey Bylokhov : > I am not an expert here, I just look to the changes and run the closed > tests for

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8191814: Marlin rasterizer spends time computing geometry for stroked segments that do not intersect the clip

I am not an expert here, I just look to the changes and run the closed tests for jdk_desktop group. No new issues were found, so it looks fine to me. On 05/12/2017 06:30, Laurent Bourgès wrote: Hi again, Here is a new webrev fixing the ClipShapeTest:

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8191814: Marlin rasterizer spends time computing geometry for stroked segments that do not intersect the clip

Hi again, Here is a new webrev fixing the ClipShapeTest: http://cr.openjdk.java.net/~lbourges/marlin/marlin-082-8191814.1/ Changes: - @run twice to test both Marlin variants (float / double) - use Logger to get & check marlin system properties ("sun.java2d.renderer.clip.runtime.enable") to

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8191814: Marlin rasterizer spends time computing geometry for stroked segments that do not intersect the clip

Hi Sergey, Thanks for your comment. This new test only validates the new clipping algorithms ie it compares the rendering outputs with / without clipping enabled. As such algorithms are only available in Marlin 0.8.2 and the test uses new system properties to enable/disable clipping, I confirm

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8191814: Marlin rasterizer spends time computing geometry for stroked segments that do not intersect the clip

Hi, Laurent. On 29/11/2017 14:30, Laurent Bourgès wrote: - added new ClipShapeTest (jtreg) that checks all possible combinations of (cap / join) for random polyline (Stroker) and polygons (Filler) comparing image outputs rendered with clipping enabled vs disabled I have only one note that the

[OpenJDK 2D-Dev] [10] RFR JDK-8191814: Marlin rasterizer spends time computing geometry for stroked segments that do not intersect the clip

Hi, Please review this webrev of the Marlin renderer 0.8.2 for JDK-10 (jdk/client forrest). It provides an efficient path clipper in both Stroker (float / double variants) & Filler fixing the bug JDK-8191814 I worked hard on this release since