On 16/09/2019 20:09, Alexey Ivanov wrote:
Hi Sergey,
This version looks good to me.
On 09/09/2019 23:14, Sergey Bylokhov wrote:
Hi, Alexey.
- Modality.html: The was dropped from everywhere, it does not
seems to be useful
I think was used to make a term / concept stand out from its
Hi Sergey,
This version looks good to me.
On 09/09/2019 23:14, Sergey Bylokhov wrote:
Hi, Alexey.
Thank you for the review, here is an updated version:
http://cr.openjdk.java.net/~serb/8225372/webrev.03
- GridBagLayout.html: The text about "Figures 1 and 2" was changed
-
Hi, Alexey.
Thank you for the review, here is an updated version:
http://cr.openjdk.java.net/~serb/8225372/webrev.03
- GridBagLayout.html: The text about "Figures 1 and 2" was changed
- componentProperties.html: The is added to some of the tables
- Modality.html: The was dropped from
Hi Sergey,
Sorry for my belated reply.
Please see my comments inline:
On 03/08/2019 00:56, Sergey Bylokhov wrote:
Hello.
The accessibility checker found similar issues in the private methods in
java.awt.geom.Path2D class. The spec for these methods is exposed via
serialization form.
Hello.
The accessibility checker found similar issues in the private methods in
java.awt.geom.Path2D class. The spec for these methods is exposed via
serialization form.
So we need to fix it as well:
http://cr.openjdk.java.net/~serb/8225372/webrev.02
- sergey.bylok...@oracle.com wrote:
>
Hi, Alexey.
Thank you for review, the new version is here:
Fix: http://cr.openjdk.java.net/~serb/8225372/webrev.01
Doc:
http://cr.openjdk.java.net/~serb/8225372/docs.01/api/java.desktop/module-summary.html
See comments inline:
On 14/06/2019 09:19, Alexey Ivanov wrote:
*GridBagLayout.java*
Hi Sergey,
*GridBagLayout.java*
Does it make sense to use nested lists for valid values?
It could make the presentation clearer rather than a paragraph followed
by a list.
Line 125–
Absolute Values:
{@code GridBagConstraints.NORTH}
Orientation
Hello.
Please review the fix for JDK 13.
Bug: https://bugs.openjdk.java.net/browse/JDK-8225372
Fix: http://cr.openjdk.java.net/~serb/8225372/webrev.00
Doc:
http://cr.openjdk.java.net/~serb/8225372/docs/api/java.desktop/module-summary.html
In the fix, some(most) of the issues which were
