Re: [OpenJDK 2D-Dev] [16] RFR JDK-8243674: Remove language tag length limit for iTXt chunk in PNGImageReader

ok, +1 On 31.07.2020 07:21, Jayathirth D v wrote: Thanks for the review Sergey. The extra check for length will hit only in case of corrupted chunk. Since we don’t know the exact length of “languageTag” or “Translated keyword” or “Text” we use chunkLength to calculate remaining length. This

Re: [OpenJDK 2D-Dev] [16] RFR JDK-8243674: Remove language tag length limit for iTXt chunk in PNGImageReader

+1 -phil. On 7/30/20, 3:55 PM, Sergey Bylokhov wrote: Hi, Jay. The fix looks fine, but maybe we can to trigger added IIOException(remainingLen < 0) by the test? On 29.07.2020 02:41, Jayathirth D v wrote: Hello All, Please review the following fix for JDK 16: Bug :

Re: [OpenJDK 2D-Dev] [16] RFR JDK-8243674: Remove language tag length limit for iTXt chunk in PNGImageReader

Thanks for the review Sergey. The extra check for length will hit only in case of corrupted chunk. Since we don’t know the exact length of “languageTag” or “Translated keyword” or “Text” we use chunkLength to calculate remaining length. This fix is to comply with spec. Testcase throws

Re: [OpenJDK 2D-Dev] [16] RFR JDK-8243674: Remove language tag length limit for iTXt chunk in PNGImageReader

Hi, Jay. The fix looks fine, but maybe we can to trigger added IIOException(remainingLen < 0) by the test? On 29.07.2020 02:41, Jayathirth D v wrote: Hello All, Please review the following fix for JDK 16: Bug : https://bugs.openjdk.java.net/browse/JDK-8243674 Webrev :

[OpenJDK 2D-Dev] [16] RFR JDK-8243674: Remove language tag length limit for iTXt chunk in PNGImageReader

Hello All, Please review the following fix for JDK 16: Bug : https://bugs.openjdk.java.net/browse/JDK-8243674 Webrev : http://cr.openjdk.java.net/~jdv/8243674/webrev.00/ Issue : We have