Re: [OpenJDK 2D-Dev] [8] request for review: 4892259 GIF ImageReader does not call passComplete in IIOReadUpdateListener

2013-05-16 Thread Vadim Pakhnushev
Phil, Andrew, Would you please take a look at this updated fix posted half a year ago? Thanks, Vadim On 20.11.2012 22:14, Vadim Pakhnushev wrote: Phil, That's right, interlaced images works as expected without the fix. Non-interlaced images could be considered single pass but the

Re: [OpenJDK 2D-Dev] [8] request for review: 4892259 GIF ImageReader does not call passComplete in IIOReadUpdateListener

2013-05-16 Thread Phil Race
An excellent example of why email doesn't make for a great code reviewing tool .. Approved. -phil. On 5/16/2013 12:25 PM, Vadim Pakhnushev wrote: Phil, Andrew, Would you please take a look at this updated fix posted half a year ago? Thanks, Vadim On 20.11.2012 22:14, Vadim Pakhnushev

[OpenJDK 2D-Dev] [8] request for review: 4892259 GIF ImageReader does not call passComplete in IIOReadUpdateListener

2012-11-19 Thread Vadim Pakhnushev
Hi, Please review a fix for bug 4892259: http://bugs.sun.com/view_bug.do?bug_id=4892259 http://cr.openjdk.java.net/~bae/4892259/webrev.00/ Actually GIFImageReader should not call neither passComplete, nor passStarted for non-interlaced images in the first place. So the fix is to check whether

Re: [OpenJDK 2D-Dev] [8] request for review: 4892259 GIF ImageReader does not call passComplete in IIOReadUpdateListener

2012-11-19 Thread Phil Race
Vadim, So I take it that you confirmed interlaced images do *not* exhibit this problem ? Its not obvious from the bug report that its only non-interlaced images that are the issue. I suppose a non-interlaced image could be considered a single pass but I can't find anywhere that we mandated