It appears to me that this fix has caused a regression.
When I bring up this dialog (on Linux) Print To File is always greyed out.
I think somewhere along the line you became we concerned about whether
specific value should grey it out or not that it got lost that is no longer
possible to set this
Hi Prasanta,
Changes are fine.
Thanks,
Jay
From: Prasanta Sadhukhan
Sent: Friday, July 08, 2016 4:42 PM
To: Jayathirth D V
Cc: 2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-5049012: PrintToFile option is not
disabled for flavors that do not support destination
Hi Jay,
Thanks
, July 08, 2016 4:46 AM
*To:* Prasanta Sadhukhan
*Cc:* 2d-dev
*Subject:* Re: [OpenJDK 2D-Dev] [9] RFR JDK-5049012: PrintToFile
option is not disabled for flavors that do not support destination
Ok .. +1
-phil.
On 7/1/16, 2:23 AM, Prasanta Sadhukhan wrote:
Hi Phil,
On 6/30/2016 7:50 PM
.
Thanks,
Jay
From: Philip Race
Sent: Friday, July 08, 2016 4:46 AM
To: Prasanta Sadhukhan
Cc: 2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-5049012: PrintToFile option is not
disabled for flavors that do not support destination
Ok .. +1
-phil.
On 7/1/16, 2:23 AM, Prasanta Sadhukhan
Ok .. +1
-phil.
On 7/1/16, 2:23 AM, Prasanta Sadhukhan wrote:
Hi Phil,
On 6/30/2016 7:50 PM, Philip Race wrote:
Eh ? Before your change the code was calling
isAttributeCategorySupported(), notisAttributeValueSupported()
So there was not previously a possibility of that NPE, and
my point was
Hi Phil,
On 6/30/2016 7:50 PM, Philip Race wrote:
Eh ? Before your change the code was calling
isAttributeCategorySupported(), not isAttributeValueSupported() So
there was not previously a possibility of that NPE, and my point was
now you have changed that call you need that !=null check even
Eh ? Before your change the code was calling
isAttributeCategorySupported(), notisAttributeValueSupported()
So there was not previously a possibility of that NPE, and
my point was now you have changed that call you need that !=null check
even more ..
But I think there is still a problem. Now ds
On 6/30/2016 1:15 PM, Prasanta Sadhukhan wrote:
Hi Phil,
NPE will be thrown
--
public boolean isAttributeValueSupported(Attribute attr,
DocFlavor flavor,
AttributeSet attributes) {
if (att
Hi Phil,
NPE will be thrown
--
public boolean isAttributeValueSupported(Attribute attr,
DocFlavor flavor,
AttributeSet attributes) {
if (attr == null) {
throw new NullPointerExcep
---
https://docs.oracle.com/javase/8/docs/api/javax/print/PrintService.html#isAttributeValueSupported-javax.print.attribute.Attribute-javax.print.DocFlavor-javax.print.attribute.AttributeSet-
Throws:
NullPointerException - (unchecked exception) if attrval is null.
--
So why did you remove t
Hi All,
Please review a fix for an issue where it is seen that "Print-To-File"
option is enabled even for flavors that do not support Destination attribute
even though isAttributeValueSupported for that flavor returns false.
Bug: https://bugs.openjdk.java.net/browse/JDK-5049012
webrev: http://
11 matches
Mail list logo
