Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

2016-11-04 Thread Phil Race
526 protected void validatePaper(Paper origPaper, Paper newPaper) { ... I think this method needs some careful inspection. 533 Class psClass = Class.forName("sun.print.IPPPrintService"); I am sure this reflection code is because the source class is shared but the target class is platform-specif

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

2016-09-02 Thread Prasanta Sadhukhan
We match the CUPS returned media to standard media here http://hg.openjdk.java.net/jdk9/client/jdk/file/03c248ab7484/src/java.desktop/unix/classes/sun/print/CUPSPrinter.java#l218 As per getPageSizes(), it returns the size of the media as mentioned(including margin) but the testcase actually sets

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

2016-08-18 Thread Philip Race
PS as I just mentioned in another review thread, I have a suspicion that the Media and MPA for CUPS are never matched to "standard" (pre-defined in API) ones. I don't know how much this matters - A4 when sent to printing should (he says) get matched on size to the right media but you should chec

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

2016-08-17 Thread Phil Race
The cups docs say you can get physical margins as described here : http://opensource.apple.com//source/cups/cups-62/doc/spm.shtml?txt#CUPS_API PPD files specify all of the available pages sizes and the physical margins associated with them. ... ppd_sizet_ size = ppdPag

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

2016-08-16 Thread Prasanta Sadhukhan
Hi All, On 8/11/2016 2:08 PM, Prasanta Sadhukhan wrote: Hi Phil, On 8/11/2016 3:05 AM, Phil Race wrote: There does not seem to be a link to the new webrev in here. Is it this : http://cr.openjdk.java.net/~psadhukhan/6574279/webrev.01/ ? > to default Paper (Letter in US, A4 otherwise) imageab

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

2016-08-11 Thread Prasanta Sadhukhan
Hi Phil, On 8/11/2016 3:05 AM, Phil Race wrote: There does not seem to be a link to the new webrev in here. Is it this : http://cr.openjdk.java.net/~psadhukhan/6574279/webrev.01/ ? > to default Paper (Letter in US, A4 otherwise) imageable area I don't think that will ever be A4. Where is that

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

2016-08-10 Thread Phil Race
There does not seem to be a link to the new webrev in here. Is it this : http://cr.openjdk.java.net/~psadhukhan/6574279/webrev.01/ ? > to default Paper (Letter in US, A4 otherwise) imageable area I don't think that will ever be A4. Where is that coming from ? And you still have not fixed the p

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

2016-08-05 Thread Prasanta Sadhukhan
On 8/4/2016 5:45 PM, Prasanta Sadhukhan wrote: I will override in PSPrinterJob but 1662 MediaPrintableArea mpa = 1663 (MediaPrintableArea)getPrintService(). 1664 getDefaultAttributeValue(MediaPrintableArea.class); is returning imageable area of default media of chosen printer from

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

2016-08-04 Thread Prasanta Sadhukhan
I will override in PSPrinterJob but 1662 MediaPrintableArea mpa = 1663 (MediaPrintableArea)getPrintService(). 1664 getDefaultAttributeValue(MediaPrintableArea.class); is returning imageable area of default media of chosen printer from CUPS [ all supported medi

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

2016-08-03 Thread Philip Race
High-level question. Why is this not an over-ride in PSPrinterJob ? I'm afraid I did not get much past the first line of the change : 1662 MediaPrintableArea mpa = 1663 (MediaPrintableArea)getPrintService(). 1664 getDefaultAttr

[OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

2016-07-12 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue where it is seen that if user sets invalid imageablearea via Paper.setImageableArea and then calls PrinterJob.validatePage() in linux, then it does not get a valid pageformat Bug: https://bugs.openjdk.java.net/browse/JDK-6574279 webrev: http://cr.openj