Re: [OpenJDK 2D-Dev] [9] RFR JDK-7064425: PageFormat Dialog has no owner window to reactivate

2016-09-13 Thread Jayathirth D V
ore review. Thanks, Jay From: Philip Race Sent: Saturday, September 10, 2016 12:32 AM To: Prasanta Sadhukhan Cc: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-7064425: PageFormat Dialog has no owner window to reactivate Sorry, right that won't work .. this is an expression eva

Re: [OpenJDK 2D-Dev] [9] RFR JDK-7064425: PageFormat Dialog has no owner window to reactivate

2016-09-09 Thread Philip Race
Sorry, right that won't work .. this is an expression evaluation and the compiler needs to determine the return type which is going to end up back as Window as the most-specific super-type. Details in 15.25.3 http://docs.oracle.com/javase/specs/jls/se8/html/jls-15.html#jls-15.25 So it won't hel

Re: [OpenJDK 2D-Dev] [9] RFR JDK-7064425: PageFormat Dialog has no owner window to reactivate

2016-09-01 Thread Prasanta Sadhukhan
Hi Phil, Please find the modified webrev http://cr.openjdk.java.net/~psadhukhan/7064425/webrev.02/ This takes care of removing DialogOwner attribute before printDialog returns. However, I could not use the same optimisation in WPrinterJob as mentioned >>/WPrintDialog dialog = new WPrintDi

Re: [OpenJDK 2D-Dev] [9] RFR JDK-7064425: PageFormat Dialog has no owner window to reactivate

2016-08-31 Thread Phil Race
911 public boolean printDialog(final PrintRequestAttributeSet attributes) ... 956 attributes.add(new DialogOwner((Frame)w)); So this now adds the DialogOwner to the attribute set passed by the application. This needs to be guaranteed to be removed again before the metho

Re: [OpenJDK 2D-Dev] [9] RFR JDK-7064425: PageFormat Dialog has no owner window to reactivate

2016-08-26 Thread Prasanta Sadhukhan
Hi All, I have modified the webrev to take care of JDK-6948907 : sun.print.DialogOwner does not support Dialogs as DialogOwner also. http://cr.openjdk.java.net/~psadhukhan/7064425/webrev.01/ Tested on windows and ubuntu. Regards Prasanta On 8

[OpenJDK 2D-Dev] [9] RFR JDK-7064425: PageFormat Dialog has no owner window to reactivate

2016-08-25 Thread Prasanta Sadhukhan
Hi All, Please review a fix for jdk9 for an issue where it is seen that PageDialog and PrintDialog is not associated with the owner Frame that spawns the dialog. Bug: https://bugs.openjdk.java.net/browse/JDK-7064425 webrev: http://cr.openjdk.java.net/~psadhukhan/7064425/webrev.00/ The issue