Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

+1 On 24.08.16 3:49, Brian Burkhalter wrote: OK unless there are objections from Sergey tomorrow I will plan to push it as-is. Thanks, Brian On Aug 23, 2016, at 5:12 PM, Philip Race > wrote: Still fine with me. -phil. On 8/23/16,

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

OK unless there are objections from Sergey tomorrow I will plan to push it as-is. Thanks, Brian On Aug 23, 2016, at 5:12 PM, Philip Race wrote: > Still fine with me. > > -phil. > > On 8/23/16, 4:18 PM, Brian Burkhalter wrote: >> >> Hi Sergey, >> >> I have added

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

Still fine with me. -phil. On 8/23/16, 4:18 PM, Brian Burkhalter wrote: Hi Sergey, I have added some comments in both the source and the test: http://cr.openjdk.java.net/~bpb/8149562/webrev.03/ Please indicate whether you think this

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

Hi Sergey, I have added some comments in both the source and the test: http://cr.openjdk.java.net/~bpb/8149562/webrev.03/ Please indicate whether you think this is sufficient. The CCC request has been approved therefore pushing this code is pending only review approval. Thanks, Brian On Aug

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

On 23.08.16 21:41, Sergey Bylokhov wrote: Is it possible, just for the record, to provide a comment why NPE was changed to IAE. I meant the first check node==null. actually this code looks a little bit strange: 493 } catch (NullPointerException npe) { 494 throw new

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

I could do that but the most recent revision does not look like that. Thanks, Brian On Aug 23, 2016, at 11:41 AM, Sergey Bylokhov wrote: > Is it possible, just for the record, to provide a comment why NPE was changed > to IAE. actually this code looks a little

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

OK I have updated the test accordingly: http://cr.openjdk.java.net/~bpb/8149562/webrev.02/ 458 try { 459 TIFFField.createFromMetadataNode(ts, null); 460 } catch (IllegalArgumentException e) { 461 ok = true; 462 } Thanks, Brian On Aug 23,

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

Whilst there is no harm in the cause of the IAE being NPE, unless it is precisely called out in the spec - which it is not - all it says is "Note that a cause might be set on such an exception." which is non-specific, I don't think the test should check for it. -phil. On 8/23/2016 11:17 AM,

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

Here is a revision based on the CCC request discussion: http://cr.openjdk.java.net/~bpb/8149562/webrev.01/ It was necessary slightly to modify one test as well. Thanks, Brian On Aug 17, 2016, at 10:39 AM, Phil Race wrote: > +1 > > -phil. > > On 08/16/2016 09:02 AM,

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

+1 -phil. On 08/16/2016 09:02 AM, Brian Burkhalter wrote: Please review at your convenience. Issue:https://bugs.openjdk.java.net/browse/JDK-8149562 Patch:[1] Add one sentence to the TIFFField.createFromMetadataNode method specification stating that the supplied Node parameter must adhere to

[OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8149562 Patch: [1] Add one sentence to the TIFFField.createFromMetadataNode method specification stating that the supplied Node parameter must adhere to the TIFFField element structure defined by the TIFF