+1.
Regards
Prasanta
On 07/14/2016 01:34 AM, Prahalad Kumar Narayanan wrote:
Hello Everyone
Good day to you.
A quick follow up on the bug fix for : JDK-8152971
First, Thanks to Phil for his time in review.
I ‘ve incorporated Phil ‘s suggestions and the webrev with
modifications are
Approved.
-phil.
On 07/14/2016 01:34 AM, Prahalad Kumar Narayanan wrote:
Hello Everyone
Good day to you.
A quick follow up on the bug fix for : JDK-8152971
First, Thanks to Phil for his time in review.
I ‘ve incorporated Phil ‘s suggestions and the webrev with modifications are
available
Hello Everyone
Good day to you.
A quick follow up on the bug fix for : JDK-8152971
First, Thanks to Phil for his time in review.
I ‘ve incorporated Phil ‘s suggestions and the webrev with modifications are
available under:
Link: http://cr.openjdk.java.net/~pnarayanan/8152971/webrev.05/
Much cleaner .. although I also do not think we need to explicitly
delete the local refs in
Java_sun_awt_Win32FontManager_populateFontFileNameMap0
since the return will do that.
And a little clean up .. the variable fontKeyName does not
seem to be needed any more. Just directly use FONTKEY_NT.
So far as I can see we can eliminate at least some of the clutter of the
calls to deletelocalreference by simply doing it as soon as we are done
with the reference
eg
309 familyLC = (*env)->CallObjectMethod(env, fmi->family,
310
Hello Everyone
Good day to you.
A quick follow-up on the fix for
Bug ID : JDK-8152971
Title : -Xcheck:jni - WARNING in native method
Thanks to Phil for his feedback.
The feedback was not only detailed.. but contained important links for
reference.
I 've
https://docs.oracle.com/javase/8/docs/technotes/guides/jni/spec/design.html#exception_handling
lists DeleteLocalRef as safe to call with a pending exception.
So here ...
74 fullnameLC = (*env)->CallObjectMethod(env, fullname,
175
Looks good to me. Only thing is in test script, you need to add
copyright 2015, 2016 as the script is originally written in 2015 and you
cannot omit the created year from the copyright.
Regards
Prasanta
On 6/27/2016 4:17 PM, Prahalad Kumar Narayanan wrote:
Hello Everyone
Good day to you.
Hello Everyone
Good day to you.
Quick follow up to fix for the Bug
Bug ID : JDK-8152971
Bug Link : https://bugs.openjdk.java.net/browse/JDK-8152971
First, Thanks to Prasanta for his review & suggestions.
I 've incorporated some of the review suggestions & updated the webrev.
I guess this method(s) should take "fontStrLC" instead of "fontStr"
650 (*env)->CallObjectMethod(env, fontToFileMap, fmi->putMID,
651 fontStr, fileStr);
692 (*env)->CallObjectMethod(env, fontToFileMap, fmi->putMID,
693
Hello Everyone on Java2D Forum
Good day to you.
A Quick follow-up on webrev to fix the following issue
Bug ID : JDK-8152971 / -Xcheck:jni - warning in native method
Bug Link : https://bugs.openjdk.java.net/browse/JDK-8152971?filter=-1
Updated webrev link:
Hello Everyone, on Java2D Group
Good day to you.
Please find herewith, webrev changes to fix the bug-
Bug ID : JDK-8152971 / -Xcheck:jni - warning in native method
Bug Link : https://bugs.openjdk.java.net/browse/JDK-8152971?filter=-1
Webrev :
12 matches
Mail list logo
