khov ; awt-
> d...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>
> Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor
> issues in awt coding
>
> I didn't eyeball what you changed but JPRT is now happy.
> The build passes on all platforms...
>
> -phil.
ov
Cc: awt-...@openjdk.java.net; 2d-dev<2d-dev@openjdk.java.net>
Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor
issues in awt coding
I tried it .. and just as well I did. It fails in the crypto code on Mac.
jdk/src/jdk.crypto.ec/share/native/libsunec/impl/ec.c:261:12: error:
expressio
-Original Message-
> From: Phil Race [mailto:philip.r...@oracle.com]
> Sent: Monday, December 05, 2016 7:26 PM
> To: Lindenmaier, Goetz ; Sergey Bylokhov
>
> Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>
> Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix mi
to:philip.r...@oracle.com]
Sent: Friday, December 02, 2016 8:46 PM
To: Lindenmaier, Goetz ; Sergey Bylokhov
Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>
Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor
issues in awt coding
I had no other comments, except that i
..@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>
> Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor
> issues in awt coding
>
> I had no other comments, except that it would be good to be sure
> that this builds on all relevant platforms .. using the 'blessed&
alization to me.
Best regards,
Goetz.
-Original Message-
From: Phil Race [mailto:philip.r...@oracle.com]
Sent: Mittwoch, 30. November 2016 20:59
To: Sergey Bylokhov ; Lindenmaier, Goetz
; Vincent Ryan
Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>; security-
d..
security-
> d...@openjdk.java.net
> Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues
> in awt coding
>
> Sorry. it is
> ops->GetRasInfo(env, ops, lockInfo);
> that initialises it ..
>
>
> That is still before the dereference
> Anyway, what
iginal Message-
From: Phil Race [mailto:philip.r...@oracle.com]
Sent: Mittwoch, 30. November 2016 20:59
To: Sergey Bylokhov ; Lindenmaier, Goetz
; Vincent Ryan
Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>; security-
d...@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev]
khan' ; Phil Race
> ; Sergey Bylokhov ;
> Vincent Ryan
> Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>; security-
> d...@openjdk.java.net
> Subject: RE: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues
> in awt coding
>
> Hi Prasanta,
nt Ryan
> Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>; security-
> d...@openjdk.java.net
> Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues
> in awt coding
>
> Also, in gtk3_interface.c, there is this change for color.alpha
>
>
> 22
ginal Message-
> From: Phil Race [mailto:philip.r...@oracle.com]
> Sent: Mittwoch, 30. November 2016 20:59
> To: Sergey Bylokhov ; Lindenmaier, Goetz
> ; Vincent Ryan
> Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>; security-
> d...@openjdk.java.net
>
Hi Christoph,
I changed the code in fontpath.c to use snprintf, that seems much
better as the concatenated string is a literal anyways.
Also, I fixed the spaces.
I'll post a new webrev once I'm through all the reviews.
Best regards,
Goetz.
> -Original Message-
> From: Langer, Chris
yes, this is a potential issue. But actually cases MID,FOCUS,BLACK,WHITE
are never used.
But the fix is wrong. It should be
color.alpha = 1; --Semyon
On 01.12.2016 08:05, Prasanta Sadhukhan wrote:
Also, in gtk3_interface.c, there is this change for color.alpha
2219 color.alpha = 0; in gtk3
Also, in gtk3_interface.c, there is this change for color.alpha
2219 color.alpha = 0; in gtk3_get_color_for_flags()
but it is used in
gtk3_get_color_for_state() where it is not initialized
2268 GdkRGBA color;
Regards
Prasanta
On 12/1/2016 1:28 AM, Phil Race wrote:
Hi Goetz,
DataBuffer
Hi Goetz,
DataBufferNative.c
Using uninitialized value lockInfo.rasBase when calling DBN_GetPixelPointer.
75 lockInfo.resBase = NULL;
Did you actually compile this ? The variable is called "rasBase", not
"resBase".
And strictly there is no problem since inside DBN_GetPixelPointer
Hi Goetz,
I have some small remarks.
src/java.desktop/unix/native/common/awt/fontpath.c:
247 fontDirPath[sizeof(fontDirPath)-1] = '\0';
-> you should add spaces left and right of '-'
248 strncat(fontDirPath, "/fonts.dir", sizeof(fontDirPath) -
strlen(fontDirPath));
-> I
cc 2d-dev.
On 30.11.16 18:41, Lindenmaier, Goetz wrote:
Hi Vincent,
thanks for the quit review!
Good catch that I lost the change to p11_mutex.c ... I had to change
it and it fell out of my patches.
I edited the Last Modified Date, and also updated the copyright messages.
New webrev:
http://cr.
17 matches
Mail list logo
