Re: [OpenJDK 2D-Dev] 2 small xrender fixes

2010-07-08 Thread Phil Race
On 7/8/2010 12:40 PM, Clemens Eisserer wrote: Hi Phil, I see the problem now. I looked at what T2K (the rasteriser) reports, but in the non-T2K glue code we then make an adjustment in the case of LCD glyphs which simply should never have been applied in the case of an empty image. It has ne

Re: [OpenJDK 2D-Dev] 2 small xrender fixes

2010-07-08 Thread Clemens Eisserer
Hi Phil, > I see the problem now. I looked at what T2K (the rasteriser) reports, but > in the non-T2K glue code we then make an adjustment in the case of LCD > glyphs > which simply should never have been applied in the case of an empty image. > It has never affected any of our code as I think we

Re: [OpenJDK 2D-Dev] 2 small xrender fixes

2010-07-07 Thread Phil Race
I see the problem now. I looked at what T2K (the rasteriser) reports, but in the non-T2K glue code we then make an adjustment in the case of LCD glyphs which simply should never have been applied in the case of an empty image. It has never affected any of our code as I think we only truly use th

Re: [OpenJDK 2D-Dev] 2 small xrender fixes

2010-07-07 Thread Clemens Eisserer
Hi Phil, Strange, running your test I get width=-1 when uploading as well as rendering the glyph - and the pipeline basically just reads the native GlyphInfo structure by using Unsafe. > I'll have to think about it a bit more .. Anything I could to to help to track that down? Thanks, Clemens

Re: [OpenJDK 2D-Dev] 2 small xrender fixes

2010-07-01 Thread Clemens Eisserer
Hi Phil, The whitespace one, I'm not aware that T2K will do this. > I find that it sets it width and height to zero for whitespace. > I instrumented the rasteriser and ran with code like this. > Wow, actually that took me quite a while to figure out what was going wrong. T2K does set width=-1 f

Re: [OpenJDK 2D-Dev] 2 small xrender fixes

2010-06-23 Thread Clemens Eisserer
Hi Phil, > I thought I sent this email last week but I just found a very patient > thunderbird compose window :-( No problem, thanks for the reply Until next week I am (again) really busy, after that I have plenty of time to investigate the issue :) I also have another fix which resolves some pr

Re: [OpenJDK 2D-Dev] 2 small xrender fixes

2010-06-22 Thread Phil Race
Clemens, I thought I sent this email last week but I just found a very patient thunderbird compose window :-( For the record, anyone with an openjdk user id should be able to upload webrevs to cr.openjdk.java.net. As to the fixes : The Jules one looks fine. I can create you a bug ID. The wh

Re: [OpenJDK 2D-Dev] 2 small xrender fixes

2010-06-15 Thread Andrew John Hughes
On 15 June 2010 14:40, Clemens Eisserer wrote: > Hi, > > I would like to get two (very small) changes to the xrender-pipeline in: > > 1. http://93.83.133.214/ignore-whitespace-width.zip deals with the > fact that the closed-source > font rasterizer seems to generate width=65535 for whitespaces, wh

[OpenJDK 2D-Dev] 2 small xrender fixes

2010-06-15 Thread Clemens Eisserer
Hi, I would like to get two (very small) changes to the xrender-pipeline in: 1. http://93.83.133.214/ignore-whitespace-width.zip deals with the fact that the closed-source font rasterizer seems to generate width=65535 for whitespaces, which resuts in software fallbacks. Granted with height=0 rend