On 02/19/2014 02:59 PM, Henry Jen wrote:
On 02/19/2014 01:46 PM, Phil Race wrote:
W.r.t the following change ...
http://cr.openjdk.java.net/~henryjen/jdk9/8033716/1/webrev/src/share/classes/com/sun/imageio/plugins/jpeg/DHTMarkerSegment.java.sdiff.html
145 class Htable implements
Hello Henry,
please see my comments regrading the fallthrough warnings inline.
On 2/20/2014 12:05 PM, Henry Jen wrote:
On 02/19/2014 02:59 PM, Henry Jen wrote:
On 02/19/2014 01:46 PM, Phil Race wrote:
W.r.t the following change ...
On 02/19/2014 01:46 PM, Phil Race wrote:
.
http://cr.openjdk.java.net/~henryjen/jdk9/8033716/1/webrev/src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java.sdiff.html
230 public IteratorImageTypeSpecifier getImageTypes(int
imageIndex) throws IIOException {
Nitpicky perhaps,
Thanks Joe for reviewing.
I would like to get 2d developer review as well before pushing this, let
me know if that's not necessary.
Also there was a discussion ealier on whether such change should go to
client or jdk9/dev repo, do we have a conclusion?
Cheers,
Henry
On 02/05/2014 06:01
Yes, it should get 2d review and I will look at this soon as priorities
permit but the *conclusion* is that the client team
ask that such changes go into the client forest. If this is a problem for
you then we will do it on your behalf. We do not want client changes
directly into dev. That is a
BMPMetadata.java
94 // Fields from CommentExtension
95 // List of byte[]
96 public Listbyte[] comments = null; // new ArrayList();
hmm .. how did you decide this was correct, other than trusting the comment?
The thing is I can't actually see where this field is used and I'm
On 2/7/2014 2:20 PM, Phil Race wrote:
Yes, it should get 2d review and I will look at this soon as priorities
permit but the *conclusion* is that the client team
ask that such changes go into the client forest. If this is a problem for
you then we will do it on your behalf. We do not want client
On 02/07/2014 03:00 PM, Phil Race wrote:
BMPMetadata.java
94 // Fields from CommentExtension
95 // List of byte[]
96 public Listbyte[] comments = null; // new ArrayList();
hmm .. how did you decide this was correct, other than trusting the
comment?
For this one, I took it
Hi Henry,
On 02/05/2014 12:19 PM, Henry Jen wrote:
Hi,
Please review the webrev to clean up raw and unchecked warnings in
com.sun.imageio packag at,
http://cr.openjdk.java.net/~henryjen/jdk9/8033716/0/webrev/
The more significant change in this webrev is that I have changed the
clone()
