Thank you for reviewing!
I pushed:
http://hg.openjdk.java.net/jdk9/client/jdk/rev/38185af88d22
Yasumasa
On 2016/07/02 5:35, Kim Barrett wrote:
On Jul 1, 2016, at 4:17 PM, Phil Race wrote:
Hi,
You have 3 reviewers (2 client, 1 build) so I am OK for this to be
> On Jul 1, 2016, at 4:17 PM, Phil Race wrote:
>
> Hi,
>
> You have 3 reviewers (2 client, 1 build) so I am OK for this to be pushed.
> If Kim comes back with some more information the a new fix can be devised ..
Hi,
You have 3 reviewers (2 client, 1 build) so I am OK for this to be pushed.
If Kim comes back with some more information the a new fix can be devised ..
-phil.
On 06/29/2016 05:44 PM, Philip Race wrote:
Hi,
Not just yet. Whilst I am OK with it ...
1) We like 2 (two) reviewers to approve.
Hi,
Not just yet. Whilst I am OK with it ...
1) We like 2 (two) reviewers to approve.
2) I would like Kim to reply to the questions so I understand
his concerns first.
-phil.
On 6/29/16, 4:30 PM, Yasumasa Suenaga wrote:
Hi Kim, Phil,
Can I push this patch?
It has been reviewed.
Hi Kim, Phil,
Can I push this patch?
It has been reviewed.
http://cr.openjdk.java.net/~ysuenaga/JDK-8160294/webrev.01/
Thanks,
Yasumasa
On 2016/06/29 2:38, Phil Race wrote:
On 06/27/2016 08:50 PM, Yasumasa Suenaga wrote:
Hi Kim,
The newest changes for jdk repos is [1].
Erik points we
On 06/27/2016 08:50 PM, Yasumasa Suenaga wrote:
Hi Kim,
The newest changes for jdk repos is [1].
Erik points we should use DISABLED_WARNINGS_gcc to handle unknown
warning tags. [2]
[1] is implemented with it.
This change is already reviewed by 2d folks.
So I want to merge it ASAP.
Do you
Hi Kim,
The newest changes for jdk repos is [1].
Erik points we should use DISABLED_WARNINGS_gcc to handle unknown warning tags.
[2]
[1] is implemented with it.
This change is already reviewed by 2d folks.
So I want to merge it ASAP.
Do you have any objection?
Thanks,
Yasumasa
[1]