On 10/30/2012 12:35 PM, Clemens Eisserer wrote:
Hi,
Looks good to go.
Thanks =)
It would be great if somebody could commit the patch, please.
I'll commit this for you.
And it would be good to file the performance issue for
small numbers of rectangles in Jira...
Has Jira been opened to
Done. And I filed
JDK-8003381: Xrender slower than X11 for filling very small (1x1) rectangles
with relevant info from the discussion.
-phil.
On 11/13/2012 4:13 PM, Phil Race wrote:
On 10/30/2012 12:35 PM, Clemens Eisserer wrote:
Hi,
Looks good to go.
Thanks =)
It would be great if
Looks good to go. And it would be good to file the performance issue
for small numbers of rectangles in Jira...
...jim
On 10/12/2012 1:24 PM, Clemens Eisserer wrote:
Hi Jim,
One comment on code style - if is not a function call so the style
guidelines specify a
Have you done any performance testing to see if the new protections cost
any performance?
One comment on code style - if is not a function call so the style
guidelines specify a space before the parentheses with the conditional
test (line 128 and 135).
The logic looks fine, but I'll point
Hi Jim,
Sorry it took so long - could you please have a look at
http://cr.openjdk.java.net/~ceisserer/7105461/webrev.02
It does now protect against integer overflow, using the Region.clipAdd.
Thanks, Clemens
2012/4/17 Jim Graham james.gra...@oracle.com:
This code doesn't protect against
Hi Clemens,
Is the clip guaranteed to be rectangular here? Or is the clipping code
only meant to optimize the region of interest being processed?
In either case, I think the intersectsQuickCheckXYXY method might work
better since it does the entire test in one go and it if this code has
to
This code doesn't protect against integer overflow. We don't protect
against it in many places, but it couldn't hurt to get in the habit. I
think the Region code has some methods that do safe addition of integers
with simple limit clipping that would work fine for rectangle dimensions.
Looks OK to me. I'd like Jim can take a look too ..
-phil.
On 4/13/12 2:15 PM, Clemens Eisserer wrote:
Hi Phil,
Thanks for taking a look.
Fix looks reasonable and good to have a fix for this!
I do think it would be safer to be better than the X11 pipeline if possible
I reworked the
Hi Clemens,
Fix looks reasonable and good to have a fix for this!
I do think it would be safer to be better than the X11 pipeline if
possible ..
-phil.
On 4/13/2012 9:46 AM, Clemens Eisserer wrote:
Hi,
Please take a look at the patch for bug 7105461, located at
Hi Phil,
Thanks for taking a look.
Fix looks reasonable and good to have a fix for this!
I do think it would be safer to be better than the X11 pipeline if possible
I reworked the original patch a bit and put the checks at a higher
level, based on the following two assumptions:
- Clipping
10 matches
Mail list logo
