Re: [OpenJDK 2D-Dev] RFR: 6436374: Graphics.setColor(null) is not documented [v2]

2021-02-03 Thread Sergey Bylokhov
On Wed, 3 Feb 2021 08:28:05 GMT, Prasanta Sadhukhan wrote: >> Document setting null setColor similar to way setFont(null) is documented. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Add test Marked as reviewed

Re: [OpenJDK 2D-Dev] RFR: 6436374: Graphics.setColor(null) is not documented [v2]

2021-02-03 Thread Prasanta Sadhukhan
> Document setting null setColor similar to way setFont(null) is documented. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Add test - Changes: - all: https://git.openjdk.java.net/jdk/pull/2371/files - new:

Re: [OpenJDK 2D-Dev] RFR: 6436374: Graphics.setColor(null) is not documented

2021-02-03 Thread Sergey Bylokhov
On Wed, 3 Feb 2021 07:59:15 GMT, Prasanta Sadhukhan wrote: >> While CSR is under review, maybe we can add a small test? > > What will be the objective of the test...It's just documentation change..no > code is changed...setting null will be ignored before this and after this > change... This

Re: [OpenJDK 2D-Dev] RFR: 6436374: Graphics.setColor(null) is not documented

2021-02-03 Thread Prasanta Sadhukhan
On Wed, 3 Feb 2021 07:57:17 GMT, Sergey Bylokhov wrote: >>> >>> >>> @mrserb has indicated that a [compatibility and >>> specification](https://wiki.openjdk.java.net/display/csr/Main) (CSR) >>> request is needed for this pull request. >>> @prsadhuk please create a CSR request and add link to

Re: [OpenJDK 2D-Dev] RFR: 6436374: Graphics.setColor(null) is not documented

2021-02-03 Thread Sergey Bylokhov
On Wed, 3 Feb 2021 07:39:54 GMT, Prasanta Sadhukhan wrote: >> Marked as reviewed by pbansal (Reviewer). > >> >> >> @mrserb has indicated that a [compatibility and >> specification](https://wiki.openjdk.java.net/display/csr/Main) (CSR) request >> is needed for this pull request. >> @prsadhuk

Re: [OpenJDK 2D-Dev] RFR: 6436374: Graphics.setColor(null) is not documented

2021-02-02 Thread Pankaj Bansal
On Wed, 3 Feb 2021 07:04:22 GMT, Prasanta Sadhukhan wrote: > Document setting null setColor similar to way setFont(null) is documented. Marked as reviewed by pbansal (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2371

Re: [OpenJDK 2D-Dev] RFR: 6436374: Graphics.setColor(null) is not documented

2021-02-02 Thread Prasanta Sadhukhan
On Wed, 3 Feb 2021 07:38:02 GMT, Pankaj Bansal wrote: >> Document setting null setColor similar to way setFont(null) is documented. > > Marked as reviewed by pbansal (Reviewer). > > > @mrserb has indicated that a [compatibility and >

Re: [OpenJDK 2D-Dev] RFR: 6436374: Graphics.setColor(null) is not documented

2021-02-02 Thread Sergey Bylokhov
On Wed, 3 Feb 2021 07:04:22 GMT, Prasanta Sadhukhan wrote: > Document setting null setColor similar to way setFont(null) is documented. Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2371

[OpenJDK 2D-Dev] RFR: 6436374: Graphics.setColor(null) is not documented

2021-02-02 Thread Prasanta Sadhukhan
Document setting null setColor similar to way setFont(null) is documented. - Commit messages: - 6436374: Graphics.setColor(null) is not documented Changes: https://git.openjdk.java.net/jdk/pull/2371/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2371=00 Issue: