On Tue, 8 Sep 2020 21:16:10 GMT, Sergey Bylokhov wrote:
> It is intended that our draw machinery works only on specific image formats
> that we know we support.
> But the user still able to create some image subclasses for their purpose and
> according to our spec of
> Graphics2D.drawImage()
On Wed, 9 Sep 2020 16:50:22 GMT, Phil Race wrote:
> I have very mixed feelings about this whole idea.
> InvalidPipeException is being co-opted for a different purpose.
We already use this exception in such cases, and I think it is intended for
this:
On Tue, 8 Sep 2020 21:16:10 GMT, Sergey Bylokhov wrote:
> It is intended that our draw machinery works only on specific image formats
> that we know we support.
> But the user still able to create some image subclasses for their purpose and
> according to our spec of
> Graphics2D.drawImage()
It is intended that our draw machinery works only on specific image formats
that we know we support.
But the user still able to create some image subclasses for their purpose and
according to our spec of
Graphics2D.drawImage() we should not throw any exceptions.
I suggest handling this
Hi, Phil.
Also now we have more checks for specific known image types.
VolatileImage is an abstract class and I'm surprised that this is something
this fix
considers OK for subclasses to extend. Does that really work ?
This is a good question I'll double-check that.
You are right, we do not
On 26.08.2020 11:27, Philip Race wrote:
Can you please add an evaluation to the bug report explaining what you intend
to do.
Will do.
The submitter of that bug was clearly hoping that we'd support custom Image
subclasses
and this fix just changes the behaviour from an IAE (or similar) to
Can you please add an evaluation to the bug report explaining what you
intend to do.
The submitter of that bug was clearly hoping that we'd support custom
Image subclasses
and this fix just changes the behaviour from an IAE (or similar) to
silently ignoring them.
I'm not sure what benefit there
Hello.
Please review the fix for jdk/client.
Bug: https://bugs.openjdk.java.net/browse/JDK-7183828
Fix: http://cr.openjdk.java.net/~serb/7183828/webrev.00
Our DrawImage pipe, used as low-level machinery to draw the known type of
images, supports only
three types of images:
- ToolkitImage -
