Re: [OpenJDK 2D-Dev] RFR: 8136783: Run blessed-modifier-order script on java.desktop

2015-09-21 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. 19.09.2015 23:14, Sergey Bylokhov пишет: Looks fine. Thanks! On 19.09.15 22:39, Phil Race wrote: Let me do that as separate review. There are also demos and tests do this is not the last of it anyway but this is a big one to get out of the way -

Re: [OpenJDK 2D-Dev] RFR: 8136783: Run blessed-modifier-order script on java.desktop

2015-09-19 Thread Sergey Bylokhov
Looks fine. Thanks! On 19.09.15 22:39, Phil Race wrote: Let me do that as separate review. There are also demos and tests do this is not the last of it anyway but this is a big one to get out of the way -Phil. On Sep 19, 2015, at 12:01 PM, Sergey Bylokhov wrote: Hi, Phil. What I am upd

Re: [OpenJDK 2D-Dev] RFR: 8136783: Run blessed-modifier-order script on java.desktop

2015-09-19 Thread Phil Race
Let me do that as separate review. There are also demos and tests do this is not the last of it anyway but this is a big one to get out of the way -Phil. > On Sep 19, 2015, at 12:01 PM, Sergey Bylokhov > wrote: > > Hi, Phil. >> >> >> What I am updating here is all the files under src/java.d

Re: [OpenJDK 2D-Dev] RFR: 8136783: Run blessed-modifier-order script on java.desktop

2015-09-19 Thread Sergey Bylokhov
Hi, Phil. What I am updating here is all the files under src/java.desktop which is a decent-sized chunk.: 324 files. I recommend looking at the jdk.patch file What about src/java.datatransfer module?(it was extracted from desktop) I have checked the changes myself visually but also used JP

Re: [OpenJDK 2D-Dev] RFR: 8136783: Run blessed-modifier-order script on java.desktop

2015-09-18 Thread Martin Buchholz
Looks good to me! On Fri, Sep 18, 2015 at 2:37 PM, Phil Race wrote: > http://cr.openjdk.java.net/~prr/8136783/ > https://bugs.openjdk.java.net/browse/JDK-8136783 > > The idea here is to have our sources follow the > recommended order fom the JLS which is further documented here > > https://docs.

[OpenJDK 2D-Dev] RFR: 8136783: Run blessed-modifier-order script on java.desktop

2015-09-18 Thread Phil Race
http://cr.openjdk.java.net/~prr/8136783/ https://bugs.openjdk.java.net/browse/JDK-8136783 The idea here is to have our sources follow the recommended order fom the JLS which is further documented here https://docs.oracle.com/javase/8/docs/api/java/lang/reflect/Modifier.html#toString-int- For bac