Re: [OpenJDK 2D-Dev] RFR: 8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux [v2]

2020-09-09 Thread Kevin Rushforth
On Wed, 9 Sep 2020 23:17:21 GMT, Sergey Bylokhov wrote: >> This the only test which was created to check different types of >> interpolation. >> It checks the rendering to the VolatileImage and uses BufferedImage as a >> gold image. >> But it does not take into account that rendering to the

Re: [OpenJDK 2D-Dev] RFR: 8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux [v2]

2020-09-09 Thread Sergey Bylokhov
> This the only test which was created to check different types of > interpolation. > It checks the rendering to the VolatileImage and uses BufferedImage as a gold > image. > But it does not take into account that rendering to the VolatileImage might > be affected > by the HiDPI support. > >

Re: [OpenJDK 2D-Dev] RFR: 8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux

2020-09-09 Thread Kevin Rushforth
On Tue, 8 Sep 2020 21:54:43 GMT, Sergey Bylokhov wrote: > This the only test which was created to check different types of > interpolation. > It checks the rendering to the VolatileImage and uses BufferedImage as a gold > image. > But it does not take into account that rendering to the

Re: [OpenJDK 2D-Dev] RFR: 8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux

2020-09-09 Thread Prasanta Sadhukhan
On Tue, 8 Sep 2020 21:54:43 GMT, Sergey Bylokhov wrote: > This the only test which was created to check different types of > interpolation. > It checks the rendering to the VolatileImage and uses BufferedImage as a gold > image. > But it does not take into account that rendering to the

Re: [OpenJDK 2D-Dev] RFR: 8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux

2020-09-08 Thread Phil Race
On Tue, 8 Sep 2020 21:54:43 GMT, Sergey Bylokhov wrote: > This the only test which was created to check different types of > interpolation. > It checks the rendering to the VolatileImage and uses BufferedImage as a gold > image. > But it does not take into account that rendering to the

[OpenJDK 2D-Dev] RFR: 8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux

2020-09-08 Thread Sergey Bylokhov
This the only test which was created to check different types of interpolation. It checks the rendering to the VolatileImage and uses BufferedImage as a gold image. But it does not take into account that rendering to the VolatileImage might be affected by the HiDPI support. Old review request:

Re: [OpenJDK 2D-Dev] RFR: 8171303 sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux

2020-09-03 Thread Ajit Ghaisas
> On 02-Sep-2020, at 10:46 AM, Sergey Bylokhov > wrote: > > On 01.09.2020 03:42, Ajit Ghaisas wrote: >>> >>> In the HiDPI mode the VolatileImage internally have twice more pixels than >>> BufferedImage, so when we draw the data to >>> the VolatileImage and then scale it back to the size of

Re: [OpenJDK 2D-Dev] RFR: 8171303 sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux

2020-09-01 Thread Sergey Bylokhov
On 01.09.2020 03:42, Ajit Ghaisas wrote: In the HiDPI mode the VolatileImage internally have twice more pixels than BufferedImage, so when we draw the data to the VolatileImage and then scale it back to the size of the BufferedImage for comparison, the test fails. This looks good. I checked

Re: [OpenJDK 2D-Dev] RFR: 8171303 sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux

2020-08-25 Thread Sergey Bylokhov
On 25.08.2020 14:59, Philip Race wrote: This is fine but 1) I like to see the bug under which you fixed it in the @bug list. It is not a product bug and the test isn't reworked, so it is not necessary to have this test fix in the list of bugs 2) I am not sure I see how all the various

Re: [OpenJDK 2D-Dev] RFR: 8171303 sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux

2020-08-25 Thread Philip Race
This is fine but 1) I like to see the bug under which you fixed it in the @bug list. 2) I am not sure I see how all the various reasons for this test failing can be explained by this. -phil. On 8/25/20, 1:37 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk/client. Bug:

[OpenJDK 2D-Dev] RFR: 8171303 sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux

2020-08-25 Thread Sergey Bylokhov
Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-8171303 Fix: http://cr.openjdk.java.net/~serb/8171303/webrev.00 This the only test which was created to check different types of interpolation. It checks the rendering to the VolatileImage and uses