Re: [OpenJDK 2D-Dev] RFR: 8175984 : ICC_Profile has un-needed, not-empty finalize method

2019-10-23 Thread Jayathirth Rao
Changes are fine. Thanks, Jay > On 11-Oct-2019, at 2:01 PM, Philip Race wrote: > > Bug: ICC_Profile has un-needed, not-empty finalize method > Webrev: http://cr.openjdk.java.net/~prr/8175984/ > > This is a native memory utilisation problem due to delay in collecting and > freeing ICC_Profiles

Re: [OpenJDK 2D-Dev] RFR: 8175984 : ICC_Profile has un-needed, not-empty finalize method

2019-10-11 Thread Sergey Bylokhov
On 10/11/19 3:43 pm, Philip Race wrote: On 10/11/19, 2:52 PM, Sergey Bylokhov wrote: Hi, Phil. It looks like after the fix we will skip the call "unregisterDeferral" and the ProfileActivator which was registered by the "ProfileDeferralMgr.registerDeferral" will not be removed --> memory leak?

Re: [OpenJDK 2D-Dev] RFR: 8175984 : ICC_Profile has un-needed, not-empty finalize method

2019-10-11 Thread Philip Race
On 10/11/19, 2:52 PM, Sergey Bylokhov wrote: Hi, Phil. It looks like after the fix we will skip the call "unregisterDeferral" and the ProfileActivator which was registered by the "ProfileDeferralMgr.registerDeferral" will not be removed --> memory leak? I discussed that below in my

Re: [OpenJDK 2D-Dev] RFR: 8175984 : ICC_Profile has un-needed, not-empty finalize method

2019-10-11 Thread Philip Race
PS .. BTW do we have an option to mark this "finalize" as forRemoval=true or just delete it?(example JDK-8159009/JDK-8212198) This will be for a backport, so that would be inappropriate even if I wanted to address that now .. -phil.

Re: [OpenJDK 2D-Dev] RFR: 8175984 : ICC_Profile has un-needed, not-empty finalize method

2019-10-11 Thread Sergey Bylokhov
Hi, Phil. It looks like after the fix we will skip the call "unregisterDeferral" and the ProfileActivator which was registered by the "ProfileDeferralMgr.registerDeferral" will not be removed --> memory leak? BTW do we have an option to mark this "finalize" as forRemoval=true or just delete

[OpenJDK 2D-Dev] RFR: 8175984 : ICC_Profile has un-needed, not-empty finalize method

2019-10-11 Thread Philip Race
Bug: ICC_Profile has un-needed, not-empty finalize method Webrev: http://cr.openjdk.java.net/~prr/8175984/ This is a native memory utilisation problem due to delay in collecting and freeing ICC_Profiles and their associated classes and data. The color management engine is native code and