On Mon, 25 Jan 2021 15:09:35 GMT, Alexey Ivanov wrote:
> Yet I suggest fixing the typo in the bug synopsis: Intermiitent → Intermittent
I've edited the JBS synopsis. Please also update the PR subject.
-
PR: https://git.openjdk.java.net/jdk/pull/2220
On Fri, 29 Jan 2021 04:03:29 GMT, Prasanta Sadhukhan
wrote:
> It seems "m_breakMessageLoop" is never true for unsuccessful run even though
> AwtToolkit::QuitMessageLoop finish execution (where m_breakMessageLoop is set
> to true),
> so AwtToolkit::MessageLoop never ends and shutdown hook gets
On Thu, 28 Jan 2021 19:50:56 GMT, Sergey Bylokhov wrote:
>>>
>>> My point is that this is not a test bug, so the test should not be changed.
>>
>> The test never dispose of the frame. Why is it expected to shut down the
>> toolkit? Shall the frame be disposed of when the main thread in the
On Thu, 28 Jan 2021 12:02:54 GMT, Alexey Ivanov wrote:
> The test never dispose of the frame. Why is it expected to shut down the
> toolkit? Shall the frame be disposed of when the main thread in the test
> finishes?
The shutdown is caused by the System.exit call while the toolkit active, so
On Thu, 28 Jan 2021 11:57:06 GMT, Alexey Ivanov wrote:
>> It seems in successful run, when the test finish
>> - AwtToolkit::MessageLoop starts
>> - DoQuitMessageLoop is called
>> - AwtToolkit::QuitMessageLoop starts
>> - AwtToolkit::QuitMessageLoop finishes
>> - AwtToolkit::MessageLoop finish
On Thu, 28 Jan 2021 09:59:22 GMT, Prasanta Sadhukhan
wrote:
>> Please take a look at the "AwtToolkit::Dispose()" method, on how much stuff
>> should be done to properly shutdown the toolkit. This Dispose() method is
>> executed immediately when we exit the message loop in the
>>
On Thu, 28 Jan 2021 05:53:05 GMT, Sergey Bylokhov wrote:
>> My point is that this is not a test bug, so the test should not be changed.
>
> Please take a look at the "AwtToolkit::Dispose()" method, on how much stuff
> should be done to properly shutdown the toolkit. This Dispose() method is
>
On Thu, 28 Jan 2021 00:41:13 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Toolkit.cpp line 2611:
>>
>>> 2609: Sleep(100);
>>> 2610: }
>>> 2611:
>>
>> It can cause infinite looping as the message queue to get DISPOSE events is
>> removed so if
> This test was failing in our nightly mach5 testing. Appropriate stability
> code in form of waitForIdle and delay is added.
> mach5 job running for several iterations on all platforms is ok. Link in JBS.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit
