Re: [OpenJDK 2D-Dev] RFR: 8250894 : Provide a configure option to build and run against the platform libharfbuzz

2020-07-31 Thread Erik Joelsson
On 2020-07-31 12:56, Philip Race wrote: Done : http://cr.openjdk.java.net/~prr/8250894.1/ Although it makes the webrev noisier .. Yes, but I prefer future readability. :) Looks good now, thanks! /Erik -phil. On 7/31/20, 11:48 AM, Erik Joelsson wrote: Hello Phil, Looks good. The only

Re: [OpenJDK 2D-Dev] RFR: 8250894 : Provide a configure option to build and run against the platform libharfbuzz

2020-07-31 Thread Philip Race
Done : http://cr.openjdk.java.net/~prr/8250894.1/ Although it makes the webrev noisier .. -phil. On 7/31/20, 11:48 AM, Erik Joelsson wrote: Hello Phil, Looks good. The only thing I would ask is that you indent everything in the else clause in Awt2dLibraries.gmk. Thanks /Erik On

Re: [OpenJDK 2D-Dev] RFR: 8250894 : Provide a configure option to build and run against the platform libharfbuzz

2020-07-31 Thread Erik Joelsson
Hello Phil, Looks good. The only thing I would ask is that you indent everything in the else clause in Awt2dLibraries.gmk. Thanks /Erik On 2020-07-31 10:58, Philip Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8250894 webrev : http://cr.openjdk.java.net/~prr/8250894/ Since

[OpenJDK 2D-Dev] RFR: 8250894 : Provide a configure option to build and run against the platform libharfbuzz

2020-07-31 Thread Philip Race
bug: https://bugs.openjdk.java.net/browse/JDK-8250894 webrev : http://cr.openjdk.java.net/~prr/8250894/ Since https://bugs.openjdk.java.net/browse/JDK-8249821 has now separated out libharfbuzz from libfontmanager, it would be natural for distros to want to link against the libharfbuzz that they