On Sat, 3 Oct 2020 00:31:48 GMT, Sergey Bylokhov wrote:
>> We have a number of missing javadoc tags and comments in the desktop module.
>> Most of the missing comments are related to the serialized form.
>>
>> The fix:
>> - Adds missing comments to the non-static/non-transient fields(even
>>
On Sat, 3 Oct 2020 03:57:21 GMT, Sergey Bylokhov wrote:
>>> I need advice about what exact change should be reviewed in the CSR(except
>>> PeerFixer removal)
>>
>> Probably almost all of it.
>
> The PeerFixer is extracted to the separate CR:
> https://bugs.openjdk.java.net/browse/JDK-8253965
>
On Fri, 2 Oct 2020 19:46:10 GMT, Phil Race wrote:
>> I think the main thing here is I would separate out removing the duplicate
>> PeerFixer into a new bug.
>>
>> I also see that the CSR is still just a pure template.
>
>> I need advice about what exact change should be reviewed in the
> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
>
> The fix:
> - Adds missing comments to the non-static/non-transient fields(even
> private) of the "serializable" classes
> - Adds comments to
On Fri, 2 Oct 2020 18:35:25 GMT, Phil Race wrote:
>> We have a number of missing javadoc tags and comments in the desktop module.
>> Most of the missing comments are related to the serialized form.
>>
>> The fix:
>> - Adds missing comments to the non-static/non-transient fields(even
>>
On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov wrote:
> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
>
> The fix:
> - Adds missing comments to the non-static/non-transient fields(even
>
On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov wrote:
> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
>
> The fix:
> - Adds missing comments to the non-static/non-transient fields(even
>
On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov wrote:
> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
>
> The fix:
> - Adds missing comments to the non-static/non-transient fields(even
>
On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov wrote:
> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
>
> The fix:
> - Adds missing comments to the non-static/non-transient fields(even
>
On Mon, 28 Sep 2020 06:30:31 GMT, Jayathirth D V wrote:
> Inputs from
> https://mail.openjdk.java.net/pipermail/beans-dev/2020-August/000424.html are
> incorporated or is this fresh
> git review?
It is a fresh update, it changes from the old review request. I made it less
"dangerous".
On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov wrote:
> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
>
> The fix:
> - Adds missing comments to the non-static/non-transient fields(even
>
We have a number of missing javadoc tags and comments in the desktop module.
Most of the missing comments are related to the serialized form.
The fix:
- Adds missing comments to the non-static/non-transient fields(even private)
of the "serializable" classes
- Adds comments to the
Hello.
Please review the fix for jdk/client.
Bug: https://bugs.openjdk.java.net/browse/JDK-8251123
Fix: http://cr.openjdk.java.net/~serb/8251123/webrev.01
We have a number of missing javadoc tags and comments in the desktop module.
Most of the missing comments are related to the serialized
13 matches
Mail list logo
