On Wed, 10 Feb 2021 21:40:46 GMT, Gerard Ziemski wrote:
>> Changes requested by gziemski (Committer).
>
> I tried to code review the native implementation files, but Metal APIs is
> brand new to me and it's been a long while since I worked with graphics API,
> so I can't be of much help
On Mon, 8 Feb 2021 23:07:39 GMT, Gerard Ziemski wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Lanai PR#175 - 8261304 - aghaisas
>
> Changes requested by gziemski (Committer).
I tried to code review the native
On Mon, 8 Feb 2021 18:05:02 GMT, Gerard Ziemski wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Lanai PR#175 - 8261304 - aghaisas
>
> src/java.desktop/macosx/classes/sun/java2d/metal/MTLRenderQueue.java line 97:
>
On Mon, 8 Feb 2021 16:53:16 GMT, Gerard Ziemski wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Lanai PR#175 - 8261304 - aghaisas
>
> src/java.desktop/macosx/classes/sun/awt/CGraphicsDevice.java line 113:
>
>>
On Mon, 8 Feb 2021 14:22:27 GMT, Kevin Rushforth wrote:
>> I think, a generic name is OK as the path of shader file already has both
>> awt (libawt_lwawt) and java2d in it.
>
> In the source tree, yes, but not in the jdk image where it ends up in
> `$JAVA_HOME/lib/shaders.metallib`. I don't
On Mon, 8 Feb 2021 12:28:07 GMT, Ajit Ghaisas wrote:
>> **Description :**
>> This is the implementation of [JEP 382 : New macOS Rendering
>> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
>> It implements a Java 2D internal rendering pipeline for macOS using the
>> Apple Metal
On Mon, 8 Feb 2021 12:28:07 GMT, Ajit Ghaisas wrote:
>> **Description :**
>> This is the implementation of [JEP 382 : New macOS Rendering
>> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
>> It implements a Java 2D internal rendering pipeline for macOS using the
>> Apple Metal
On Mon, 8 Feb 2021 17:15:25 GMT, Gerard Ziemski wrote:
> General comment - I am not sure I like the `MTL` prefix acronym in names (ex.
> `sun.java2d.metal.MTLVolatileSurfaceManager`).
>
> I think you tried to match the `CGL`, but that is a real acronym that stands
> for "Core Graphics Layer"
On Mon, 8 Feb 2021 17:15:25 GMT, Gerard Ziemski wrote:
>> The file in `RenderPerfTest` should have a GPLv2 license header (no
>> Classpath). I filed
>> [JDK-8261273](https://bugs.openjdk.java.net/browse/JDK-8261273) and also
>> highlighted a couple examples below.
>
> General comment - I am
On Sat, 6 Feb 2021 00:53:08 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Lanai PR#175 - 8261304 - aghaisas
>
> The file in `RenderPerfTest` should have a GPLv2 license header (no
>
On Mon, 8 Feb 2021 13:40:22 GMT, Ajit Ghaisas wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 894:
>>
>>> 892: SHADERS_SUPPORT_DIR :=
>>> $(SUPPORT_OUTPUTDIR)/native/java.desktop/libosxui
>>> 893: SHADERS_AIR := $(SHADERS_SUPPORT_DIR)/shaders.air
>>> 894: SHADERS_LIB :=
On Fri, 5 Feb 2021 18:42:02 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Lanai PR#175 - 8261304 - aghaisas
>
> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 894:
>
>> 892:
> **Description :**
> This is the implementation of [JEP 382 : New macOS Rendering
> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
> It implements a Java 2D internal rendering pipeline for macOS using the Apple
> Metal API.
> The entire work on this was done under [OpenJDK Project
13 matches
Mail list logo
