Re: [OpenJDK 2D-Dev] RFR: JDK-8196803: Fix build warnings in jdk libraries with Xcode 9

2018-02-06 Thread Erik Joelsson
Hello, The 9 was just me being sloppy and thinking 9.x, I'm actually using 9.2. These are all the warnings I found in JDK libraries. There are additional ones in other parts of the build which have been dealt with in separate issues. /Erik On 2018-02-06 12:54, Sergey Bylokhov wrote: Hi, E

Re: [OpenJDK 2D-Dev] RFR: JDK-8196803: Fix build warnings in jdk libraries with Xcode 9

2018-02-06 Thread Sergey Bylokhov
Hi, Erik. Why XCode 9 was selected? It seems that 9.2 is the latest one. 9.2 produces some additional warnings even after this fix. On 05/02/2018 14:54, Erik Joelsson wrote: When building with Xcode 9, we get some warnings triggered in jdk libraries. This patch tries to fix them. See bug descrip

Re: [OpenJDK 2D-Dev] RFR: JDK-8196803: Fix build warnings in jdk libraries with Xcode 9

2018-02-06 Thread Magnus Ihse Bursie
On 2018-02-05 23:54, Erik Joelsson wrote: When building with Xcode 9, we get some warnings triggered in jdk libraries. This patch tries to fix them. See bug description for more details on each of them. In short the following things are addressed: In src/java.desktop/macosx/native/libosxapp/N

Re: [OpenJDK 2D-Dev] RFR: JDK-8196803: Fix build warnings in jdk libraries with Xcode 9

2018-02-05 Thread Tim Bell
Erik: Webrev: http://cr.openjdk.java.net/~erikj/8196803/webrev.01/index.html Bug: https://bugs.openjdk.java.net/browse/JDK-8196803 Looks good. /Tim

[OpenJDK 2D-Dev] RFR: JDK-8196803: Fix build warnings in jdk libraries with Xcode 9

2018-02-05 Thread Erik Joelsson
When building with Xcode 9, we get some warnings triggered in jdk libraries. This patch tries to fix them. See bug description for more details on each of them. In short the following things are addressed: In src/java.desktop/macosx/native/libosxapp/NSApplicationAWT.m, remove the check on MAC_