Re: [OpenJDK 2D-Dev] RFR 8225160: Merge JDK-8220154 initial metal implementation patch to the jdk sandbox branch

Hello All, Thanks for the review. Changes are merged into the sandbox. Made some more changes in sandbox like JDK-8226560 and took mainline changes into our metal-prototype-branch. We can take latest change from this sandbox branch and work

Re: [OpenJDK 2D-Dev] RFR 8225160: Merge JDK-8220154 initial metal implementation patch to the jdk sandbox branch

I'm OK with this. We will doubtless incrementally revisit everything before we are done. -phil. On 6/20/19, 12:52 PM, Kevin Rushforth wrote: As long as you've addressed all Phil's concerns, it looks OK to me. -- Kevin On 6/20/2019 5:57 AM, Jayathirth Rao wrote: Hi Alexey, Thanks for the

Re: [OpenJDK 2D-Dev] RFR 8225160: Merge JDK-8220154 initial metal implementation patch to the jdk sandbox branch

As long as you've addressed all Phil's concerns, it looks OK to me. -- Kevin On 6/20/2019 5:57 AM, Jayathirth Rao wrote: Hi Alexey, Thanks for the review. Removed new trace definitions and there references. Webrev without traces : http://cr.openjdk.java.net/~jdv/8225160/webrev.02/

Re: [OpenJDK 2D-Dev] RFR 8225160: Merge JDK-8220154 initial metal implementation patch to the jdk sandbox branch

Hi Alexey, Thanks for the review. Removed new trace definitions and there references. Webrev without traces : http://cr.openjdk.java.net/~jdv/8225160/webrev.02/ Regards, Jay > On 20-Jun-2019, at 12:00 AM, Alexey Ushakov > wrote: > >

Re: [OpenJDK 2D-Dev] RFR 8225160: Merge JDK-8220154 initial metal implementation patch to the jdk sandbox branch

Hello Jay and Phil, This changes looks good for me. > 5) Time tracing for primitive drawing was present in JetBrain’s code so we > took it. It may hamper overall performance while drawing, if it is not needed > we can remove it. Concerning the logging we can remove it. The junit

Re: [OpenJDK 2D-Dev] RFR 8225160: Merge JDK-8220154 initial metal implementation patch to the jdk sandbox branch

Hi Phil, Thanks for your inputs. 1) Removed MetalKit reference in make file 2) Removed reference to sun.java2d.metal in jdk8_packages.dat file. 3) For pipeline selection logic, I have created new sub-task JDK-8226384 4) Removed MetalKit

[OpenJDK 2D-Dev] RFR 8225160: Merge JDK-8220154 initial metal implementation patch to the jdk sandbox branch

Hello All, Please review the below code changes: JBS : https://bugs.openjdk.java.net/browse/JDK-8225160 We have merged most of the code provided for review by JetBrains for JDK-8220154 to