Re: [OpenJDK 2D-Dev] Request for review: JDK-7159455 : Nimbus scrollbar rendering glitch with xrender enabled on i945GM

2013-10-03 Thread Clemens Eisserer
Hi Jim, Apologies as this is an old bug, but I just looked at the fix and it seems to me that it will allow shearing transforms to pass because the tests are incomplete. The 0or180 flag only tests if the horizontal lines stay horizontal, but they could shift relative to each other in

Re: [OpenJDK 2D-Dev] Request for review: JDK-7159455 : Nimbus scrollbar rendering glitch with xrender enabled on i945GM

2013-09-04 Thread Clemens Eisserer
the fix looks fine to me. Thanks. Please commit. Regards, Clemens

Re: [OpenJDK 2D-Dev] Request for review: JDK-7159455 : Nimbus scrollbar rendering glitch with xrender enabled on i945GM

2013-09-02 Thread Andrew Brygin
Hello Clemens, the fix looks fine to me. Thanks, Andrew On 8/29/2013 11:19 PM, Clemens Eisserer wrote: Hi, Please review my fix for: JDK-7159455 : Nimbus scrollbar rendering glitch with xrender enabled on i945GM available at: http://cr.openjdk.java.net/~ceisserer/7159455/webrev.00/ Problem

Re: [OpenJDK 2D-Dev] Request for review: JDK-7159455 : Nimbus scrollbar rendering glitch with xrender enabled on i945GM

2013-08-30 Thread Phil Race
Looks reasonable to me. Need someone else to review too. -phil. On 8/29/2013 12:19 PM, Clemens Eisserer wrote: Hi, Please review my fix for: JDK-7159455 : Nimbus scrollbar rendering glitch with xrender enabled on i945GM available at: http://cr.openjdk.java.net/~ceisserer/7159455/webrev.00/