Re: [OpenJDK 2D-Dev] Review Request: JDK-6457721: Stroke width incorrect while printing

2016-06-21 Thread Prahalad Kumar Narayanan
am Cc: prasanta sadhukhan; Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review Request: JDK-6457721: Stroke width incorrect while printing For a different situation, PathGraphics does this :- if ((getTransform().getType() & ~( AffineTransform.TYPE_UNIF

Re: [OpenJDK 2D-Dev] Review Request: JDK-6457721: Stroke width incorrect while printing

2016-06-21 Thread Philip Race
For a different situation, PathGraphics does this :- if ((getTransform().getType() & ~( AffineTransform.TYPE_UNIFORM_SCALE | AffineTransform.TYPE_TRANSLATION | AffineTransform.TYPE_QUADRANT_ROTATION )) != 0) { return false;

Re: [OpenJDK 2D-Dev] Review Request: JDK-6457721: Stroke width incorrect while printing

2016-06-07 Thread Jim Graham
The calculations are still not correct. Consider a transform that zooms Y coordinates and shrinks X coordinates, you will think that the resulting line width is large, and it will be for horizontal lines. But vertical lines will experience a smaller line width. The only real calculation to s

Re: [OpenJDK 2D-Dev] Review Request: JDK-6457721: Stroke width incorrect while printing

2016-06-07 Thread prasanta sadhukhan
Fix looks good to me. But, do we not need to do the same for 209 minLineWidth = Math.max(Math.abs(minPenSize.x) 210 Math.abs(minPenSize.y)); For the test the instruction textarea is editable which needs to be made read-only. Also,

[OpenJDK 2D-Dev] Review Request: JDK-6457721: Stroke width incorrect while printing

2016-06-07 Thread Prahalad Kumar Narayanan
Hello Everyone on Java2D Good day to you. Please find herewith: Webrev changes for the bug Bug ID : JDK-6457721 Bug Link : https://bugs.openjdk.java.net/browse/JDK-6457721 As per the Bug: 1. With rotation angle set to Graphics2D object, the printed Lines, Recta