Re: [OpenJDK 2D-Dev] Review Request: Small tweak in the DrawImage.java

2015-11-17 Thread Sergey Bylokhov
Bug filed: 8143150: DrawImagePipe can skip some unnecessary blits https://bugs.openjdk.java.net/browse/JDK-8143150 On 13.11.15 23:43, Jim Graham wrote: Looks good! ...jim On 11/13/2015 12:12 PM, Sergey Bylokhov wrote: On 13.11.15 1:50, Jim Graham wrote: I can add a comment that

Re: [OpenJDK 2D-Dev] Review Request: Small tweak in the DrawImage.java

2015-11-13 Thread Jim Graham
Looks good! ...jim On 11/13/2015 12:12 PM, Sergey Bylokhov wrote: On 13.11.15 1:50, Jim Graham wrote: I can add a comment that this code is for performance, what do you think? I'd like to see that, was there an updated diff? In either case, I don't think we should di

Re: [OpenJDK 2D-Dev] Review Request: Small tweak in the DrawImage.java

2015-11-13 Thread Sergey Bylokhov
On 13.11.15 1:50, Jim Graham wrote: I can add a comment that this code is for performance, what do you think? I'd like to see that, was there an updated diff? In either case, I don't think we should disturb the comment and test at the top, we should just add additional checks down below where

Re: [OpenJDK 2D-Dev] Review Request: Small tweak in the DrawImage.java

2015-11-12 Thread Jim Graham
Hi Sergey, On 11/12/2015 1:54 PM, Sergey Bylokhov wrote: On 12.11.15 23:46, Jim Graham wrote: Hi Sergey, I think the added logic is fine, but I would hesitate removing all of those lines with comments simply because: - In terms of code generated it is no more efficient to do the tests up abov

Re: [OpenJDK 2D-Dev] Review Request: Small tweak in the DrawImage.java

2015-11-12 Thread Jim Graham
Hi Sergey, I think the added logic is fine, but I would hesitate removing all of those lines with comments simply because: - In terms of code generated it is no more efficient to do the tests up above or down below. - Your question below does not indicate enough investigation to remove tha

Re: [OpenJDK 2D-Dev] Review Request: Small tweak in the DrawImage.java

2015-11-12 Thread Sergey Bylokhov
On 12.11.15 23:46, Jim Graham wrote: Hi Sergey, I think the added logic is fine, but I would hesitate removing all of those lines with comments simply because: - In terms of code generated it is no more efficient to do the tests up above or down below. - Your question below does not indicate e

[OpenJDK 2D-Dev] Review Request: Small tweak in the DrawImage.java

2015-11-12 Thread Sergey Bylokhov
Hello. Can somebody take a look to the small enhancement for DrawImage.java. I will file a new CR if the proposed change will be approved: http://cr.openjdk.java.net/~serb/perf/DrawImageItself.01/src/java.desktop/share/classes/sun/java2d/pipe/DrawImage.java.sdiff.html The goal is to minimize the