Hi Phil,
Fix looks good. Is there a way you can check in a regression test along-side
the fix
else you'll need to add a 'noreg-some reason' label on the JBS bug.
Thanks for the review - I'll write a regression test today.
- Clemens
Hi Phil,
Please find the regression test at:
http://cr.openjdk.java.net/~ceisserer/8054638/WhiteTextColorTest.java
Thanks, Clemens
Hi Clemens,
It needs the GPL license (copied from another test to get the right one)
and there's one typo : wether - whether
Otherwise looks fine.
-phil.
On 8/26/2014 11:44 AM, Clemens Eisserer wrote:
Hi Phil,
Please find the regression test at:
It needs the GPL license (copied from another test to get the right one)
and there's one typo : wether - whether
Header added, thanks for finding the typo:
http://cr.openjdk.java.net/~ceisserer/8054638/WhiteTextColorTest.java
Otherwise looks fine.
In case no other issues pop up and a second
Andrew or Jennifer : can you add your review 2c
The 8u backport is worth doing as we have had 2 independent reports
of this. That backport needs to be approved by the 8u gatekeeper.
I can take care of that once this is in 9.
-phil.
On 8/26/14 12:25 PM, Clemens Eisserer wrote:
It needs the GPL
Hello Clemens,
the fix and the test look fine to me. The test probably can be
simplified a bit
with using getSnapshot() method of VolatileImage class, but it does
not matter
much here.
Thanks,
Andrew
On 8/26/2014 11:35 PM, Phil Race wrote:
Andrew or Jennifer : can you add your review 2c
Hi Clemens,
Fix looks good. Is there a way you can check in a regression test
along-side the fix
else you'll need to add a 'noreg-some reason' label on the JBS bug.
-phil.
On 8/12/2014 10:33 PM, Clemens Eisserer wrote:
Sorry, forgot to include the link to the webrev:
Hello,
Please review my fix for JDK-8054638 xrender: text drawn after
setColor(Color.white) is actually black.
The XRSolidSrcPict manages a small 1x1 pixmap which is used as source
surface for some operations.
To avoid redundant fillRect operations when setting it's color, the
currently set
Sorry, forgot to include the link to the webrev:
http://cr.openjdk.java.net/~ceisserer/8054638/webrev.00/
2014-08-13 7:32 GMT+02:00 Clemens Eisserer linuxhi...@gmail.com:
Hello,
Please review my fix for JDK-8054638 xrender: text drawn after
setColor(Color.white) is actually black.
The
