Hi,
You didn't answer any of these very specific and direct questions I posed :
> What precise exception happened, precisely where and precisely why ?
-phil.
On 9/2/12 7:34 PM, Sean Chou wrote:
Hi Phil,
Yes, a non-IO Exception is generated. Another catch clause is of
cause a choice;
howev
Hi Phil,
Yes, a non-IO Exception is generated. Another catch clause is of
cause a choice;
however we are thinking the return true might wide the exception too much,
so it is
modified.
On Tue, Aug 28, 2012 at 1:57 AM, Phil Race wrote:
> Hi,
>
>
> >The reason is quite straight forward as de
Hi,
>The reason is quite straight forward as described in the first mail.
>IPPPrintService.isPostscript catches all IOException and return true,
> while the try block in PSPrinterJob catches all Throwable .
>In our scenario, an non-io exception is produced in the try block and
it get executed.
Hi Phil,
On Sat, Aug 25, 2012 at 2:10 AM, Phil Race wrote:
> Hi,
>
> On 8/23/2012 10:23 PM, Sean Chou wrote:
>
>> Hi Phil,
>>
>> I'm really sorry about this typo, the modification looks so simple
>> that I became careless when porting.
>>
>
> That's a slippery slope. Only send out code that
Hi,
On 8/23/2012 10:23 PM, Sean Chou wrote:
Hi Phil,
I'm really sorry about this typo, the modification looks so simple
that I became careless when porting.
That's a slippery slope. Only send out code that you built and tested.
What if reviewer also thinks "this must be OK else it wouldn'
Hi Phil,
I'm really sorry about this typo, the modification looks so simple that
I became careless when porting.
The patch is from ibmjdk and it has been tested on Java6 since Oct,
2007 and on Java7 since Feb, 2012. To be honest, this modification isn't
related to a real bug in openjdk f
Sean,
Without even commenting on the merits or necessity I note that you
cannot possibly
have even built this patch, much less tested it.
> 625 return Boolean.FLASE;
-phil.
On 8/23/12 1:58 AM, Sean Chou wrote:
Hello,
I updated the repository to 2d, the webrev is now:
http://cr.openjdk.
Hello,
I updated the repository to 2d, the webrev is now:
http://cr.openjdk.java.net/~zhouyx/OJDK-429/webrev.01/
Please take a look.
-- Forwarded message --
From: Sean Chou
Date: Thu, Aug 23, 2012 at 2:24 PM
Subject: Suggest a modification to isPostscript exception handling
Sorry about the repository, I'll update the webrev.
On Thu, Aug 23, 2012 at 2:24 PM, Sean Chou wrote:
> Hello,
>
> This is a simple modification to sun/print/PSPrinterJob.java.
> When sun.print.IPPPrintService.isPostscript method checks if the
> printer is a postscript printer, if IOExc
Hello,
This is a simple modification to sun/print/PSPrinterJob.java.
When sun.print.IPPPrintService.isPostscript method checks if the
printer is a postscript printer, if IOException happens, the method assumes
the printer is postscript printer (IPPPrintService.java, line 1605). In
class
10 matches
Mail list logo
