Hi Phil,
do you know anybody we can contact for reporting the issue upstream?
Yes, 8u is supported on PPC64, so we need the fix before backporting.
Thanks a lot and best regards,
Martin
From: Philip Race [mailto:philip.r...@oracle.com]
Sent: Donnerstag, 28. Dezember 2017 18:09
To: Baesken, Mat
This all sounds fine to me.
Definitely we should report this upstream to see what they say but
clearly we aren't bound to wait for an answer from there since this is
a build breakage for PPC. If someone upstream
comes back with a better answer we can update the fix.
I think this png update will g
Hi Phil, I think your idea to guard with
#ifdef PNG_POWERPC_VSX_API_SUPPORTED
Is fine, should I prepare a webrev using this guard ?
* Wrapping in that check might be OK (for PNG_POWERPC_VSX_API_SUPPORTED)
but you'll want to report this upstream.
Yes it is a good idea to report this ups
I expect that will fix it but I wonder if the problem is that all of
this needs
to be guarded by checking :-
#ifdef PNG_POWERPC_VSX_API_SUPPORTED
It looks to me configure would have set that if it had been run on PPC AND
you have passed --enable-powerpc-vsx to configure
But of course I did not
Hi Matthias,
png_init_filter_functions_vsx() is implemented in:
https://sourceforge.net/p/libpng/code/ci/libpng16/tree/powerpc/powerpc_init.c#l53
Looks like the two files found in:
https://sourceforge.net/p/libpng/code/ci/libpng16/tree/powerpc/
are not merged. If you include them, for instance
>Do you have a version of libpng available that contains the missing
>function png_init_filter_functions_vsx ?
>Or do you have an idea where it should come from (I cannot find it in the main
>libpng sources).
>To fix the build, we could probably disable the part bringing in
>png_init_f
Hi Phil, it looks like the recent png lib change
8183960: Upgrade to libpng 1.6.34
http://hg.openjdk.java.net/jdk/hs/rev/791d551bcdb8
+#if PNG_POWERPC_VSX_OPT > 0
+# define PNG_FILTER_OPTIMIZATIONS png_init_filter_functions_vsx
+# define PNG_POWERPC_VSX_IMPLEMENTATION 1
+#endif
Causes buil
