Re: [OpenJDK 2D-Dev] request for review: JDK-7082809 : xrender artifacts caused by different interpretation of SRC operator

2013-10-22 Thread Phil Race
This looks good to me. It fixes the test in https://bugs.openjdk.java.net/browse/JDK-8023098 I'm going to commit under that bug ID and close 7082809 as a duplicate. Note that 7082809 points to another bug 7122456 which has a test case and this fixes that too! There are also numerous SQE tests

[OpenJDK 2D-Dev] request for review: JDK-7082809 : xrender artifacts caused by different interpretation of SRC operator

2013-10-18 Thread Clemens Eisserer
Please review my fix for bug JDK-7082809 : xrender artifacts caused by different interpretation of SRC operator located at: http://cr.openjdk.java.net/~ceisserer/7082809/webrev.05/ A manual test-case is available at: http://cr.openjdk.java.net/~ceisserer/7082809/CompositeTest.java Problem

Re: [OpenJDK 2D-Dev] request for review: JDK-7082809 : xrender artifacts caused by different interpretation of SRC operator

2013-10-18 Thread Andrew Brygin
Hi Clemens, a copyright header is missed in the new file XRSolidSrcPict.java. Could you please add it? Thanks, Andrew On 10/18/2013 12:21 PM, Clemens Eisserer wrote: Please review my fix for bug JDK-7082809 : xrender artifacts caused by different interpretation of SRC operator located at:

Re: [OpenJDK 2D-Dev] request for review: JDK-7082809 : xrender artifacts caused by different interpretation of SRC operator

2013-10-18 Thread Clemens Eisserer
Hi Andrew, a copyright header is missed in the new file XRSolidSrcPict.java. Could you please add it? Done. Please find the updated webrev at: http://cr.openjdk.java.net/~ceisserer/7082809/webrev.06/ Thanks, Clemens

Re: [OpenJDK 2D-Dev] request for review: JDK-7082809 : xrender artifacts caused by different interpretation of SRC operator

2013-10-18 Thread Andrew Brygin
Hi Clemens, from my perspective, the fix looks fine. Thanks, Andrew On 10/18/2013 2:19 PM, Clemens Eisserer wrote: Hi Andrew, a copyright header is missed in the new file XRSolidSrcPict.java. Could you please add it? Done. Please find the updated webrev at: