Re: [OpenJDK 2D-Dev] request for review: xrender pipeline ignores center-coordinates of RadialGradient

2013-10-22 Thread Andrew Brygin
Hello Clemens, I have played with the tests, and Java2D demo, and the fix looks fine to me. Thanks, Andrew On 10/20/2013 9:55 PM, Clemens Eisserer wrote: Hi, Ok, this starts to become embarrassing ... sorry for the review request spam recently. I was stressed that my changes would be

Re: [OpenJDK 2D-Dev] request for review: xrender pipeline ignores center-coordinates of RadialGradient

2013-10-22 Thread Phil Race
This looks good. I am committing it and 2 of the new tests. http://cr.openjdk.java.net/~ceisserer/fix13/TexturePaintInterpolationTest.java will indeed fail on D3D OpenGL. I'll file a bug on that, so I won't commit the test, just put it in the bug report. It passes on X11, GDI, The other 2

Re: [OpenJDK 2D-Dev] request for review: xrender pipeline ignores center-coordinates of RadialGradient

2013-10-20 Thread Clemens Eisserer
Hi, Ok, this starts to become embarrassing ... sorry for the review request spam recently. I was stressed that my changes would be submitted too late, so I submitted as soon as I had a fix for an isolated issue. During extensive testing I've found a few other issues within the xrender pipeline

Re: [OpenJDK 2D-Dev] request for review: xrender pipeline ignores center-coordinates of RadialGradient

2013-10-19 Thread Andrew Brygin
Hello Clemens, the fix looks fine to me. Thanks, Andrew On 10/18/2013 8:59 PM, Clemens Eisserer wrote: Please find a more extensive fix at: http://cr.openjdk.java.net/~ceisserer/fix13/webrev.02/ In addition to the fixes in webrev.00, this one also fixes the TexturePaint issues reported by

Re: [OpenJDK 2D-Dev] request for review: xrender pipeline ignores center-coordinates of RadialGradient

2013-10-19 Thread Clemens Eisserer
Please wait with the commit, there are a few other issues hidden in the horrors of the xrender pipeline's gradient support. 2013/10/19 Andrew Brygin andrew.bry...@oracle.com: Hello Clemens, the fix looks fine to me. Thanks, Andrew On 10/18/2013 8:59 PM, Clemens Eisserer wrote: Please

[OpenJDK 2D-Dev] request for review: xrender pipeline ignores center-coordinates of RadialGradient

2013-10-18 Thread Clemens Eisserer
Hi, Please review my fix for the issue described below at: http://cr.openjdk.java.net/~ceisserer/fix13/webrev.00/ Problem description: Phil found an issue with TransformedPaintTest, where the center point of radial gradients was stuck at (0,0) with the xrender-pipeline enabled. The center-point