On 02/10/12 03:58 AM, Michael Barker wrote:
Hi Stuart,
Thank you for the reviewing the patches. I forgot about the
Contributed-by header, sorry about that. That's one I'll put on the
list to make sure I have sorted next time. I've split the
contributors up according to the two patches supplie
Michael,
Thanks for splitting up the patches and revising them in response to the review
comments.
I'm not yet entirely sure how to proceed with pushing these changes. I think
Chris assumed that I would push these changes. Since these are in awt,
printing, and beans, the changes might need t
Hi Michael,
The changes to List.java and Window.java look fine to me.
--
best regards,
Anthony
On 2/4/2012 8:40 PM, Michael Barker wrote:
Patch with BeanSupportContext changes removed.
Mike.
On Sat, Feb 4, 2012 at 3:48 PM, Chris Hegarty wrote:
I think you should just drop the changes to th
> I see Rémi has suggested a slice & dice but I think that's a bit too much
> work for the changes involved. Instead I would suggest a simple split, send
> the AWT/Printing/Beans changes to awt-dev + 2d-dev, and everything else to
> core-libs-dev.
Attached is a patch that contains the awt/printing
> Oh, good catch Alan, I missed this. This part of the change should be
> reversed ( at least in the context of warnings cleanup ).
Should I switch it to a wild card (protected transient ArrayList
bcmListeners) or just drop the modifications for that file?
Mike.
Patch with BeanSupportContext changes removed.
Mike.
On Sat, Feb 4, 2012 at 3:48 PM, Chris Hegarty wrote:
> I think you should just drop the changes to this file.
>
> -Chris.
>
> Michael Barker wrote:
>
>>> Oh, good catch Alan, I missed this. This part of the change should be
>>> reversed ( at
I think you should just drop the changes to this file.
-Chris.
Michael Barker wrote:
>> Oh, good catch Alan, I missed this. This part of the change should be
>> reversed ( at least in the context of warnings cleanup ).
>
>Should I switch it to a wild card (protected transient ArrayList
>bcmList
On 04/02/2012 11:12, Alan Bateman wrote:
I skimmed through this and just wonder about the changes to
java.beans.beancontext.BeansSupportContext. It's a public type so adding
a type parameter to the protected bcmListeners may be an issue.
Oh, good catch Alan, I missed this. This part of th
On 04/02/2012 07:48, Michael Barker wrote:
I see Rémi has suggested a slice& dice but I think that's a bit too much
work for the changes involved. Instead I would suggest a simple split, send
the AWT/Printing/Beans changes to awt-dev + 2d-dev, and everything else to
core-libs-dev.
Attached is a
Michael,
Looks good to me.
Trivially, the generic type in ComponentBeanInfo could simply be
Class, since the actual type is not used. But, what you have is fine.
Thanks for this contribution. I'm sure Stuart will do the integration
for you.
-Chris.
On 02/ 4/12 07:48 AM, Michael Barker wr
10 matches
Mail list logo
