Re: [OpenJDK 2D-Dev] Fix for drawing round endcaps on scaled lines.

2010-07-12 Thread Denis Lila
The no argument constructor becoming private was not something I intended. It was left over from a change I made that didn't work out so well, and it escaped my mind to change it back when I sent the webrev. It's true that it's not used, and we could remove it, but it seems to me like the reason f

Re: [OpenJDK 2D-Dev] Fix for drawing round endcaps on scaled lines.

2010-07-12 Thread Denis Lila
Hello Jim. I'm terribly sorry about that. I fixed it. Now the only highlighted lines in the webrev should be lines I actually changed. Please take another look at it. (link is still the same: http://icedtea.classpath.org/~dlila/webrevs/bezierRoundJoins/webrev/) Thanks, Denis. PS: I added a new

Re: [OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

2010-07-12 Thread Denis Lila
Hello Jim. I think the second way would be better because there would be no repeated code, and it would be easier to implement. Do you think there will be any performance benefit from the first way? Regards, Denis. - "Jim Graham" wrote: > Hi Denis, > > It would be ill-advised to normalize

Re: [OpenJDK 2D-Dev] Various fixes to pisces stroke widening code

2010-07-12 Thread Denis Lila
Hello. Is it ok if I do this? I already started working on it on Friday. I think I should be done by tomorrow. But yes, I agree that we should convert to floating point. As for performance, there's also the fact that right now we're trading one double multiplication for 2 casts to long, 1 long m

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6959998: Return of SurfaceData_InitOps point not checked in all cases (parfait found these)

2010-07-12 Thread igor . nekrestyanov
Changeset: e03065fc64e7 Author:igor Date: 2010-07-12 13:16 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e03065fc64e7 6959998: Return of SurfaceData_InitOps point not checked in all cases (parfait found these) Reviewed-by: prr Contributed-by: ohair ! src/share/native/sun/

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6968373: FontUtilities static initializer throws AccessControlException

2010-07-12 Thread igor . nekrestyanov
Changeset: 2ad69cb576b4 Author:igor Date: 2010-07-12 15:11 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/2ad69cb576b4 6968373: FontUtilities static initializer throws AccessControlException Reviewed-by: prr ! src/share/classes/sun/font/FontUtilities.java ! test/java/awt/Fon