Re: [OpenJDK 2D-Dev] [8] request for review: 7124347: [macosx] "java.lang.InternalError: not implemented yet" on call Graphics2D.drawRend

2012-11-29 Thread Andrew Brygin
Hello Jim, I do not think that suggested change allows a null composite per se: the check for null was introduced just to make sure that we can safely call isDerivedFrom method. However, it does not change the method behavior for the case of null composite. If it is impossible to get null c

Re: [OpenJDK 2D-Dev] [8] request for review: 7124347: [macosx] "java.lang.InternalError: not implemented yet" on call Graphics2D.drawRend

2012-11-29 Thread Jim Graham
Hi Andrew, My belief is that comp should never be null. A simple grep should confirm that belief. While I do agree that it can be safer to check for null if you aren't sure about the code base, once one piece of code does it then it spreads and weakens the API contract so it would be better

[OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 7124223: [macosx] Regression test failure with new exception, when glyph is positioned explicitly

2012-11-29 Thread andrew . brygin
Changeset: d54db1e16b97 Author:bae Date: 2012-11-30 11:32 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d54db1e16b97 7124223: [macosx] Regression test failure with new exception, when glyph is positioned explicitly Reviewed-by: jgodinez ! src/share/classes/sun/print/PathGr