Re: [OpenJDK 2D-Dev] Request for review: : [NEW BUG] Printer - tempfile having incorrect extension

2012-12-11 Thread Jonathan Lu
Thanks a lot, Jannifer! Could anybody else please help to take a look? Best regards - Jonathan On 12/05/2012 12:22 AM, Jennifer Godinez wrote: I approve the change but we need one more reviewer before pushing the change. Jennifer On 12/3/2012 10:26 PM, jayashree viswanathan wrote: On 03-12

Re: [OpenJDK 2D-Dev] Request for review: : [NEW BUG] Printer - tempfile having incorrect extension

2012-12-11 Thread Andrew Brygin
Hello Jonathan, the change looks fine to me. Thanks, Andrew On 11.12.2012 13:14, Jonathan Lu wrote: Thanks a lot, Jannifer! Could anybody else please help to take a look? Best regards - Jonathan On 12/05/2012 12:22 AM, Jennifer Godinez wrote: I approve the change but we need one more revie

[OpenJDK 2D-Dev] [8] Request for review: 8004821 Graphics2D.drawPolygon() fails with IllegalPathStateException

2012-12-11 Thread Sergey Bylokhov
Hello, Please review the fix for jdk 8. PixelToShapeConverter.makePoly() should not try to close path in case of the empty arrays of points. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004821 Webrev can be found at: http://cr.openjdk.java.net/~serb/8004821/webrev.00 -- Best regard

[OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8004316: Printer - tempfile having incorrect extension

2012-12-11 Thread luchsh
Changeset: e8b54ae97344 Author:jviswana Date: 2012-12-12 13:28 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e8b54ae97344 8004316: Printer - tempfile having incorrect extension Reviewed-by: bae, jgodinez ! src/solaris/classes/sun/print/UnixPrintJob.java

Re: [OpenJDK 2D-Dev] Request for review: : [NEW BUG] Printer - tempfile having incorrect extension

2012-12-11 Thread Jonathan Lu
Hello Andrew, Thanks a lot for reviewing, I've pushed the patch @ http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e8b54ae97344 Cheers - Jonathan On 12/11/2012 05:59 PM, Andrew Brygin wrote: Hello Jonathan, the change looks fine to me. Thanks, Andrew On 11.12.2012 13:14, Jonathan Lu wrote: Th

Re: [OpenJDK 2D-Dev] Request for review: : [NEW BUG] Printer - tempfile having incorrect extension

2012-12-11 Thread jayashree viswanathan
On 12-12-2012 11:07 AM, Jonathan Lu wrote: Hello Andrew, Thanks a lot for reviewing, I've pushed the patch @ http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e8b54ae97344 Cheers - Jonathan On 12/11/2012 05:59 PM, Andrew Brygin wrote: Hello Jonathan, the change looks fine to me. Thanks, Andrew