Hi Sergey,
src/macosx/classes/sun/java2d/opengl/CGLLayer.java
48 private int scale = 1;
src/macosx/classes/sun/awt/CGraphicsDevice.java
222 public int getScaleFactor() {
src/macosx/classes/sun/java2d/opengl/CGLSurfaceData.java
45 protected final int scale;
(there's also o
On 3/27/13 4:12 PM, Denis S. Fokin wrote:
Hi Sergey,
why we do not use Math.round() here?
Region.java:
153 return (int) Math.floor(newv + 0.5);
Just because it one additional call.
Thank you,
Denis.
On 3/26/2013 7:33 PM, Sergey Bylokhov wrote:
Hello,
Please review the fix for jd
On 3/27/13 6:52 PM, Anthony Petrov wrote:
(there's also other usages of int in shared code)
Why do we use integer values here? There's no 100% guarantee that the
scale factor is integer on Mac (or other platforms when we support
HiDPI rendering on them). At least native APIs operate with float
Changeset: 87c62f03bc07
Author:jgodinez
Date: 2013-03-27 12:42 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/87c62f03bc07
8010005: [parfait] Memory leak in jdk/src/macosx/native/sun/awt/CTextPipe.m
Reviewed-by: bae, prr
Contributed-by: jia-hong.c...@oracle.com
! src/macosx/
Hello Phil,
Thank you very much for the review. No, the original problem consists in
the fact that Xlib function "XSetErrorHandler" is not thread-safe, so
calling it from different threads by setting one error handler and
restoring the previous error handler leads to such not easily
reproduci
Hello,
On 3/27/2013 3:08 PM, Anton Litvinov wrote:
Hello Phil,
Thank you very much for the review. No, the original problem consists
in the fact that Xlib function "XSetErrorHandler" is not thread-safe,
so calling it from different threads by setting one error handler and
restoring the previ
