Hi Jim,
Let's divide the discussion into two part.
1. Where it is better to hold resolution variants?
Putting resolution variants in Image class brings some questions like:
- Some type of images do not need to have resolution variants
- Should resolution variants have the same type as
cc 2d alias also.
The fix looks good. I am curious who will document all new options in
README-builds.html?
On 14.02.2014 21:27, Omair Majid wrote:
* Andrew Hughes [2014-02-13 23:59]:
As I said in the previous e-mail, the minimum I'd be happy with is if
the current patch was updated so sett
* Sergey Bylokhov [2014-02-18 12:35]:
> cc 2d alias also.
>
> The fix looks good. I am curious who will document all new options
> in README-builds.html?
One thing I have always loved about autotools is self documentation.
With this patch, for example, ./configure --help gives me the new option
> Anything else I should do/test?
No. Sounds fine.
-phil.
On 2/18/14 5:30 PM, Mikael Vidstedt wrote:
On 2014-02-15 09:31, Phil Race wrote:
Looks OK to me although I just realised there's no bug ID here
Bug created:
https://bugs.openjdk.java.net/browse/JDK-8035287
FWIW I develop on WIndo
Thanks for the review Phil!
Cheers,
Mikael
On 2014-02-18 17:37, Phil Race wrote:
> Anything else I should do/test?
No. Sounds fine.
-phil.
On 2/18/14 5:30 PM, Mikael Vidstedt wrote:
On 2014-02-15 09:31, Phil Race wrote:
Looks OK to me although I just realised there's no bug ID here
Bug
On 2014-02-15 09:31, Phil Race wrote:
Looks OK to me although I just realised there's no bug ID here
Bug created:
https://bugs.openjdk.java.net/browse/JDK-8035287
FWIW I develop on WIndows, Mac & Linux and I've noticed widely divergent
things that the compilers on these platforms warn about