Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2014-05-22 Thread Anton V. Tarasov
Hi Sergey, On 22.05.2014 1:44, Sergey Bylokhov wrote: On 5/21/14 10:13 PM, Anthony Petrov wrote: Hi Sergey, The original fix provides some updates and clarifications to the javadoc for the LightweightContent.imageBufferReset() method, but they are missing from your fix. Is this intentional?

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

2014-05-22 Thread Erik Joelsson
On 2014-05-22 02:49, Omair Majid wrote: * Andrew Hughes [2014-05-21 20:23]: - Original Message - * Andrew Hughes [2014-05-21 12:22]: I'm not keen on the hardcoding of '-ljpeg' + LIBJPEG_LIBS := -ljpeg There's no pkg-config files for it. Any suggestions on how to get something gen

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2014-05-22 Thread Sergey Bylokhov
On 5/22/14 11:47 AM, Anton V. Tarasov wrote: Hi Sergey, On 22.05.2014 1:44, Sergey Bylokhov wrote: On 5/21/14 10:13 PM, Anthony Petrov wrote: Hi Sergey, The original fix provides some updates and clarifications to the javadoc for the LightweightContent.imageBufferReset() method, but they ar

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2014-05-22 Thread Anton V. Tarasov
On 22.05.2014 15:36, Sergey Bylokhov wrote: On 5/22/14 11:47 AM, Anton V. Tarasov wrote: Hi Sergey, On 22.05.2014 1:44, Sergey Bylokhov wrote: On 5/21/14 10:13 PM, Anthony Petrov wrote: Hi Sergey, The original fix provides some updates and clarifications to the javadoc for the LightweightCo

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2014-05-22 Thread Sergey Bylokhov
On 5/22/14 5:58 PM, Anton V. Tarasov wrote: On 22.05.2014 15:36, Sergey Bylokhov wrote: On 5/22/14 11:47 AM, Anton V. Tarasov wrote: Hi Sergey, On 22.05.2014 1:44, Sergey Bylokhov wrote: On 5/21/14 10:13 PM, Anthony Petrov wrote: Hi Sergey, The original fix provides some updates and clarifi

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

2014-05-22 Thread Phil Race
BTW .. I just realised I haven't seen a bug ID in this thread. Does one already exist ? -phil. On 5/21/14 5:49 PM, Omair Majid wrote: * Andrew Hughes [2014-05-21 20:23]: - Original Message - * Andrew Hughes [2014-05-21 12:22]: I'm not keen on the hardcoding of '-ljpeg' + LIBJPEG_

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

2014-05-22 Thread Andrew Hughes
- Original Message - > > On 2014-05-22 02:49, Omair Majid wrote: > > * Andrew Hughes [2014-05-21 20:23]: > >> - Original Message - > >>> * Andrew Hughes [2014-05-21 12:22]: > I'm not keen on the hardcoding of '-ljpeg' > > + LIBJPEG_LIBS := -ljpeg > >>> There's n

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

2014-05-22 Thread Omair Majid
* Phil Race [2014-05-22 16:02]: > BTW .. I just realised I haven't seen a bug ID in this thread. > Does one already exist ? No. I was going to create one before I push. Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2014-05-22 Thread Anthony Petrov
Hi Sergey, http://cr.openjdk.java.net/~serb/8029455/webrev.02 The fix looks fine to me. -- best regards, Anthony On 5/22/2014 10:05 PM, Sergey Bylokhov wrote: On 5/22/14 5:58 PM, Anton V. Tarasov wrote: On 22.05.2014 15:36, Sergey Bylokhov wrote: On 5/22/14 11:47 AM, Anton V. Tarasov wrot

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

2014-05-22 Thread Anthony Petrov
I think that it would be useful to have a bug id prior to sending a review request, so that a review thread for the bug can be easily found in the mailing archive. In the future, please do file a bug first and put its id in the subject line of your review requests. -- best regards, Anthony On

[OpenJDK 2D-Dev] RFR: 8043805: Allow using a system-installed libjpeg

2014-05-22 Thread Omair Majid
* Anthony Petrov [2014-05-22 16:48]: > I think that it would be useful to have a bug id prior to sending a review > request, so that a review thread for the bug can be easily found in the > mailing archive. In the future, please do file a bug first and put its id in > the subject line of your revi

Re: [OpenJDK 2D-Dev] RFR: 8043805: Allow using a system-installed libjpeg

2014-05-22 Thread Anthony Petrov
Thanks, Omair. -- best regards, Anthony On 5/23/2014 1:01 AM, Omair Majid wrote: * Anthony Petrov [2014-05-22 16:48]: I think that it would be useful to have a bug id prior to sending a review request, so that a review thread for the bug can be easily found in the mailing archive. In the futu

[OpenJDK 2D-Dev] Please check these two 8u20 backports for 2 ICU fixes 8042850 and 8042855

2014-05-22 Thread Phil Race
JDK 9 changeset : http://hg.openjdk.java.net/jdk9/client/jdk/rev/006f772bbc7e Identical JDK 8 backport: http://cr.openjdk.java.net/~prr/8042850 JDK 9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/006f772bbc7e Identical JDK 8 backport: http://cr.openjdk.java.net/~prr/8042855 -phil.

Re: [OpenJDK 2D-Dev] Please check these two 8u20 backports for 2 ICU fixes 8042850 and 8042855

2014-05-22 Thread Phil Race
On 5/22/14 2:39 PM, Phil Race wrote: JDK 9 changeset : http://hg.openjdk.java.net/jdk9/client/jdk/rev/006f772bbc7e Sorry copy paste problems that should have been http://hg.openjdk.java.net/jdk9/client/jdk/rev/be332c33c5a0 Identical JDK 8 backport: http://cr.openjdk.java.net/~prr/8042850 JDK 9

Re: [OpenJDK 2D-Dev] Please check these two 8u20 backports for 2 ICU fixes 8042850 and 8042855

2014-05-22 Thread Jennifer Godinez
Checked. They are identical. - Jennifer On 5/22/2014 2:45 PM, Phil Race wrote: On 5/22/14 2:39 PM, Phil Race wrote: JDK 9 changeset : http://hg.openjdk.java.net/jdk9/client/jdk/rev/006f772bbc7e Sorry copy paste problems that should have been http://hg.openjdk.java.net/jdk9/client/jdk/rev/be33