Re: [OpenJDK 2D-Dev] [9] Review Request: 8066132 BufferedImage::getPropertyNames() always returns null

2015-01-15 Thread Phil Race
Approved -phil. On 1/12/2015 2:50 AM, Sergey Bylokhov wrote: Hello. Please review a fix for jdk 9. BufferedImage::getPropertyNames() was implemented according to specification. Notes: - The properties map in the constructor is defined as , which means it can have non-String keys. Long time a

Re: [OpenJDK 2D-Dev] What is the point of CloseTTFontFileFunc?

2015-01-15 Thread Phil Race
I can only suppose the author thought he was going to pass the platName (which would be the font file path) to some code that would use it to somehow close an open descriptor on that file. But clearly it does nothing of the sort and an up-call to the java font object (like in the read function) w