[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8134084: Mark client libs regression tests using randomness

2015-08-20 Thread joe darcy
Hello, As part of implementing tiered testing [1], client library tests which use randomness should be marked with the corresponding keyword. The analogous changes have been made in core libs, see JDK-8078334: Mark regression tests using randomness. Webrev at JDK-8134084 : Mark client l

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8134084: Mark client libs regression tests using randomness

2015-08-20 Thread Phil Race
Joe, How is this keyword interpreted and used ? How did you select the tests below to be so marked ? I might ask more once I understand the answers to these but looking at just one of these - MTGraphicsAccessTest.java - there is no such thing a spurious failure of this test. If you ever see a fai

Re: [OpenJDK 2D-Dev] Fwd: creating images using native code

2015-08-20 Thread Alan Snyder
I have filed an RFE . Alan > On Aug 18, 2015, at 9:58 AM, Sergey Bylokhov > wrote: > > This is 2d related question (cc 2d-dev). >> From: Alan Snyder < javali...@cbfiddle.com >>

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8134084: Mark client libs regression tests using randomness

2015-08-20 Thread joe darcy
Hi Phil, On 8/20/2015 11:14 AM, Phil Race wrote: Joe, How is this keyword interpreted and used ? From the TEST.ROOT file in the jdk/test directory: # The "randomness" keyword marks tests using randomness with test # cases differing from run to run. (A test using a fixed random seed # would n

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8134084: Mark client libs regression tests using randomness

2015-08-20 Thread Phil Race
So randomness is a keyword that is read by a human and interpreted in the process of filing a bug on the test ? The one I pointed out does not seem like it needs this treatment. If it fails there is nothing to argue about. A crash is pretty conclusive. So the others probably ought to be examined

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8134084: Mark client libs regression tests using randomness

2015-08-20 Thread joe darcy
On 8/20/2015 11:52 AM, Phil Race wrote: So randomness is a keyword that is read by a human and interpreted in the process of filing a bug on the test ? Yes, the randomness keyword is a message to the human reader of the test or someone doing analysis of a test failure. The connotation of the