Re: [OpenJDK 2D-Dev] RFR: 8143177: Integrate harfbuzz opentype layout engine per JEP 258

2015-11-18 Thread Sergey Bylokhov
Hi, Phil. Not an expert here, just a few notes: - Copyright is missing: hb-jdk-font.cc, hb-jdk.h - HBShaper.c: Do we need a code at 268? probably we can add some todo or remove it? On 18.11.15 3:05, Philip Race wrote: Webrev : http://cr.openjdk.java.net/~prr/8143177/ Bug : https://bugs.openj

Re: [OpenJDK 2D-Dev] Duplicated (or better multiplicated) image-decoder resolvers in openjdk

2015-11-18 Thread Sergey Bylokhov
Hi, Jiri. This question also related to 2d area(cc) I think it is possible to use the PNGImageReader(spi) instead of sun.awt.PNGImageDecoder, which will allow automatically handle the nondefault image formats. But as far as I know there are no plan to do it in jdk9. On 30.10.15 16:13, Jiri V

Re: [OpenJDK 2D-Dev] [rfc]Stream doesn't reset mark in finally

2015-11-18 Thread Jiri Vanek
On 11/12/2015 02:24 PM, Sergey Bylokhov wrote: Hi, Jiri. This is a valid point, did you file a new CR for this issue? Hello! here it is: https://jvanek.fedorapeople.org/oracle/jdk8/webrevs/resetInTryFinally/v1/ Patch: https://jvanek.fedorapeople.org/oracle/jdk8/webrevs/resetInTryFinally/v1/w