Re: [OpenJDK 2D-Dev] RFR 8144654: Improve Marlin logging

2015-12-08 Thread Laurent Bourgès
Jim, > Looks good. > > Is there some way to reduce the impact of not hard-coding doMonitors for future benefit? Or is that constant only for debugging modifications? Durin Marlin development, I occasionally use doMonitor to get internal timings so it is a developper feature that should remain co

Re: [OpenJDK 2D-Dev] RFR 8144828: Marlin renderer causes unaligned write accesses

2015-12-08 Thread Laurent Bourgès
Jim, I think this patch fixes properly the segfault issue on sparc as confirmed by Tobias. Le 8 déc. 2015 02:13, "Jim Graham" a écrit : > > Do we make sure that the subpixel coords don't overflow an integer somewhere? I will create a new bug related to this specific issue to handle properly coo

Re: [OpenJDK 2D-Dev] RFR: 8144858: HBShaper.c does not compiler with VS2010

2015-12-08 Thread Volker Simonis
Hi Phil, thanks for fixing this. This hit us as well. The change looks good, just a small comment: 'prevCluster' doesn't seems to be used anywhere, so I think you can completely remove it. Regards, Volker On Mon, Dec 7, 2015 at 8:52 PM, Philip Race wrote: > Bug : https://bugs.openjdk.java.net

Re: [OpenJDK 2D-Dev] CFV: New 2D Group Member: Sergey Bylokhov

2015-12-08 Thread Andrew Brygin
Vote: yes. Thanks, Andrew. On Dec 7, 2015, at 11:29 PM, Phil Race mailto:philip.r...@oracle.com>> wrote: I hereby nominate Sergey Bylokhov to membership in the 2D group. Sergey has been a de facto member of the group for a long time and has contributed numerous substantial fixes and provided m

Re: [OpenJDK 2D-Dev] RFR 8144828: Marlin renderer causes unaligned write accesses

2015-12-08 Thread Laurent Bourgès
Jim, I created the following bug to handle properly coordinate overflow: https://bugs.openjdk.java.net/browse/JDK-8144938 Cheers, Laurent 2015-12-08 9:11 GMT+01:00 Laurent Bourgès : > Jim, > > I think this patch fixes properly the segfault issue on sparc as confirmed > by Tobias. > > Le 8 déc.

Re: [OpenJDK 2D-Dev] RFR: 8144245: [PIT] javax/imageio/plugins/shared/WriteAfterAbort.java

2015-12-08 Thread Brian Burkhalter
The pre-existing WriteAfterAbort passes for all plugins; WriteToSequenceAfterAbort passes for TIFF but fails for GIF and JPEG, which are the only other plugins which can write sequences. This could be a problem in the test itself but I did not investigate further. I see also that I need to dele

[OpenJDK 2D-Dev] Question regarding the integration of harfbuzz (JEP 258)

2015-12-08 Thread Volker Simonis
Hi, the integration of harfbuzz broke our AIX build because there's no implementation available for the hb_atomic macros in hb-atomic-private.hh. I've fixed that locally but still get a crash when running a simple AWT program (even with -Dsun.font.layoutengine=icu). I'm curretnly debugging the pr

Re: [OpenJDK 2D-Dev] CFV: New 2D Group Member: Sergey Bylokhov

2015-12-08 Thread Jennifer Godinez
Vote: Yes - Jennifer On 12/07/2015 12:29 PM, Phil Race wrote: I hereby nominate Sergey Bylokhov to membership in the 2D group. Sergey has been a de facto member of the group for a long time and has contributed numerous substantial fixes and provided many code reviews. Votes are due by 21st De

Re: [OpenJDK 2D-Dev] CFV: New 2D Group Member: Sergey Bylokhov

2015-12-08 Thread Andrew Brygin
Vote: yes. Thanks, Andrew. On Dec 7, 2015, at 11:29 PM, Phil Race mailto:philip.r...@oracle.com>> wrote: I hereby nominate Sergey Bylokhov to membership in the 2D group. Sergey has been a de facto member of the group for a long time and has contributed numerous substantial fixes and provided m

Re: [OpenJDK 2D-Dev] RFR 8144446: Automate the Marlin crash test

2015-12-08 Thread Jim Graham
Hi Laurent, If this were testing a bug that crossed a number of implementation boundaries such that any number of engineers might make a change that could cause it to fail, then I might agree with the need to run it whenever any automated run of tests occurs. But, the only thing that will ca

Re: [OpenJDK 2D-Dev] RFR 8144828: Marlin renderer causes unaligned write accesses

2015-12-08 Thread Jim Graham
With the submission of JDK-8144938 as a follow-on bug, this fix looks fine now... ...jim On 12/7/15 5:13 PM, Jim Graham wrote: Do we make sure that the subpixel coords don't overflow an integer somewhere? ...jim On 12/7/15 1:52 PM, Laurent Bourgès wrote:

Re: [OpenJDK 2D-Dev] CFV: New 2D Group Member: Sergey Bylokhov

2015-12-08 Thread Jim Graham
Vote: yes ...jim

Re: [OpenJDK 2D-Dev] Review request for JDK-8143562: JPEG reader returns null for getRawImageType()

2015-12-08 Thread prasanta sadhukhan
The fix looks good to me. The spec says "Returns an |ImageTypeSpecifier| indicating the |SampleModel| and |ColorModel| which most closely represents the "raw" internal format of the image. For example, for a JPEG image the raw type might have a YCbCr color space even though the image would con