Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8069348/webrev.03
On 28/11/15 02:43, Jim Graham wrote:
Hi Alexandr,
On 11/27/15 2:06 AM, Alexander Scherbatiy wrote:
OSXOffscreenSD.java (and all *SD.java), line 481 - should we just make
this part of the SD.copyA
Hi Phil,
thanks for the review!
Maybe I was unclear, but Behdad already integrated the exact patch upstream:
https://github.com/behdad/harfbuzz/commit/70b33edae7c8b9c031b83c95f00cb383789f1041
https://github.com/behdad/harfbuzz/commit/49e72634af74a9fbad01f42f48e104218413acc0
I'm not aware of any
Only one thing remain which I would like to clarify.
In the PNGImageWriter the new field deflaterLevel was added(it can be
private?). This field is initialized by default to
DEFAULT_COMPRESSION_LEVEL and updated according to the current params.
Is it possible a situation if two images will use
Sergey,
2015-12-11 13:02 GMT+01:00 Sergey Bylokhov :
> Only one thing remain which I would like to clarify.
>
> In the PNGImageWriter the new field deflaterLevel was added(it can be
> private?). This field is initialized by default to
> DEFAULT_COMPRESSION_LEVEL and updated according to the curre
On 11/12/15 17:38, Laurent Bourgès wrote:
I fixed that issue by resetting the compression level to the default
value before using or not params.
Probably it can be made local to the write method, but this version
looks fine too.
Here is an updated webrev:
http://cr.openjdk.java.net/~lbourg
AIX can use pthread, yes.
I'll take a look at the patch. Thanks Volker for your reply.
Enviado desde nuestro iPhone.
> El dic 10, 2015, a las 6:55 AM, Behdad Esfahbod escribió:
>
> Slightly shuffled patch was committed upstream:
> https://github.com/behdad/harfbuzz/commit/70b33edae7c8b9c03
Yes I had the same trouble compiling harfbuzz. I'm close though.
Enviado desde nuestro iPhone.
> El dic 10, 2015, a las 8:12 AM, Volker Simonis
> escribió:
>
> Behdad,
>
> you're really great!!!
>
> I've forked HarfBuzz today because I wanted to submit a pull request with the
> change. Unf
I hope you're using xlC to compile harfbuzz on AIX. Using the GNU tool
chain wouldn't be fair :)
We're also using xlC for compiling the OpenJDK so GCC is no option for us.
Please let me know if you've succeeded and what you had to do. This would
be especially interesting if there will exist some m
Sergey,
>> I fixed that issue by resetting the compression level to the default
>> value before using or not params.
>
>
> Probably it can be made local to the write method, but this version looks
fine too.
You're right. I will improve that, I did it too quickly.
Maybe I should also improve other
Please review at your convenience.
Issue: https://bugs.openjdk.java.net/browse/JDK-8144997
Patch: http://cr.openjdk.java.net/~bpb/8144997/webrev.00/
Summary:
1. lines 478-481: If the IFD entry has an unknown data type, skip the entry.
2. line 528: if the offset to the field’s value is out of t
+1.
-phil.
On 12/11/2015 02:45 PM, Brian Burkhalter wrote:
Please review at your convenience.
Issue: https://bugs.openjdk.java.net/browse/JDK-8144997
Patch: http://cr.openjdk.java.net/~bpb/8144997/webrev.00/
Summary:
1. lines 478-481: If the IFD entry has an unknown data type, skip the ent
11 matches
Mail list logo
