Re: [OpenJDK 2D-Dev] [9] Review request for 8073400: Some Monospaced logical fonts have a different width

Hello, Any volunteers to review the fix? Thanks, Dmitry On 14/01/2016 13:32, dmitry markov wrote: Hello, Could you review the fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8073400 webrev: http://cr.openjdk.java.net/~dmarkov/8073400/jdk9/webrev.00/ Problem descri

[OpenJDK 2D-Dev] [9] RFR: JDK-8138749, , Revisited: PrinterJob.printDialog() does not support multi-mon, always displayed on primary

Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-8138749 webrev: http://cr.openjdk.java.net/~psadhukhan/8138749/webrev.00/ Please review a fix for a long standing issue whereby it is seen that PrinterJob.printDialog(attr set) does not support multi-monitor setup. When this API is invoked,

[OpenJDK 2D-Dev] Review request for JDK-8147413 : api/java_awt/Image/MultiResolutionImage/index.html\#MultiResolutionRenderingHints[test_VALUE_RESOLUTION_VARIANT_BASE] started to fail

Hi, Please review the following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8147413 Webrev : http://cr.openjdk.java.net/~jdv/8147413/webrev.00/ Issue : JCK testcase api/java_awt/Image/MultiResolutionImage/index.html\#MultiResolutionRenderingHints[test_VALUE_RESOLU

Re: [OpenJDK 2D-Dev] RFR: 8147443: Use Common Cleaner in Marlin OffHeapArray

Phil, Just a reminder: do you approve the last webrev ? Laurent Le 19 janv. 2016 16:32, "Laurent Bourgès" a écrit : > > Phil, > > I adopted your approach and please review the updated webrev: > http://cr.openjdk.java.net/~lbourges/marlin/marlin-Cleaner.2/ > > Changes: > - RendererContext: added

Re: [OpenJDK 2D-Dev] RFR: 8147443: Use Common Cleaner in Marlin OffHeapArray

Thanks, Phil. > Yes, sorry .. Monday was a holiday here so I am behind. > > -phil. Do we need 1 more reviewer ? Laurent

Re: [OpenJDK 2D-Dev] RFR: 8147443: Use Common Cleaner in Marlin OffHeapArray

You have me, Roger and Mandy already so that should be enough. -phil. On 1/20/2016 12:14 PM, Laurent Bourgès wrote: Thanks, Phil. > Yes, sorry .. Monday was a holiday here so I am behind. > > -phil. Do we need 1 more reviewer ? Laurent

Re: [OpenJDK 2D-Dev] RFR: 8147443: Use Common Cleaner in Marlin OffHeapArray

Yes, sorry .. Monday was a holiday here so I am behind. -phil. On 01/20/2016 11:59 AM, Laurent Bourgès wrote: Phil, Just a reminder: do you approve the last webrev ? Laurent Le 19 janv. 2016 16:32, "Laurent Bourgès" > a écrit : > > Phil, > > I adopted your

Re: [OpenJDK 2D-Dev] Review request for JDK-8147413 : api/java_awt/Image/MultiResolutionImage/index.html\#MultiResolutionRenderingHints[test_VALUE_RESOLUTION_VARIANT_BASE] started to fail

It seems like the expectation was that BASE could be drawn by the old imaging path. which would be lower overhead. I think we should ask Alexandr what the intention was here and whether the code that handles the base image needs to be taught how to extract data from a MultiResolutionImage. -phil

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8138749, , Revisited: PrinterJob.printDialog() does not support multi-mon, always displayed on primary

The changes in ServiceUI seem like they can cause the spec. to be contradicted. It says * @param gc used to select screen. null means primary or default screen. but you update the code such that it will use the active window. If that is on a secondary screen but null was passed in. I am not

[OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Hi, This is backport of the fix that is already merged into JDK9. Please review the fix in JDK8u: Bug : https://bugs.openjdk.java.net/browse/JDK-8041501 Webrev : http://cr.openjdk.java.net/~jdv/8041501.8u/webrev.00/ Issue : Pink discoloration when we read JPEG images without JFI