Isn't the problem there that we are returning an integer as the advance?
Why aren't we returning 7.35 as a value instead of 8?
Also, shouldn't 7.35 round to 7 and 14.7 round to 15?
...jim
On 2/6/2016 7:28 AM, Alexander Scherbatiy wrote:
On 05/02/16 23:39, Phil
Bug : https://bugs.openjdk.java.net/browse/JDK-8051519
This internal AP being deprecated in preparation for removal in JDK 10.
Ordinarily we would remove it directly but it is known to be used by
non-JDK code, hence the deprecation. CCC approval is already obtained
diff in-line below
diff --git
Adding missing bug synopsis to the subject line.
-phil.
On 02/08/2016 12:40 PM, Phil Race wrote:
Bug : https://bugs.openjdk.java.net/browse/JDK-8051519
This internal AP being deprecated in preparation for removal in JDK 10.
Ordinarily we would remove it directly but it is known to be used by
no
Jim & Phil,
I updated my previous webrev to have MarlinRenderingEngine TL/CLQ more
close to the new proposed approach in AAShapePipe (and looks simpler):
http://cr.openjdk.java.net/~lbourges/marlin/marlin-8148886.2/
Please give me your comments on my previous email.
Cheers,
Laurent
2016-02-06
> On Feb 8, 2016, at 12:40 PM, Phil Race wrote:
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8051519
> This internal AP being deprecated in preparation for removal in JDK 10.
> Ordinarily we would remove it directly but it is known to be used by
> non-JDK code, hence the deprecation. CCC a
Phil & Jim,
Please review a simple fix for a SEGV in Marlin renderer due to NaN
coordinates:
bug: https://bugs.openjdk.java.net/browse/JDK-8149338
webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8149338.0/
Changes:
- addLine: use first / last Y crossings to compute edge min/max Y that
You might want to separate the new ReentrantTL class into a separate
file in sun.java2d so it can be used in other places. What are the
hurdles for using it in Marlin instead of rolling its own? If it is
going to be reused it might be better to represent the ReentrantContext
class as an inter
These changes look fine, but my previous comments remain...
...jim
On 2/8/16 12:58 PM, Laurent Bourgès wrote:
Jim & Phil,
I updated my previous webrev to have MarlinRenderingEngine TL/CLQ more
close to the new proposed approach in AAShapePipe (and looks simpler):
http:/
I don't understand the issue with the fonts that you are saying have
different sizes for different DPIs. Those are pixel sizes, aren't they?
They still need to be turned into user-space units for our
applications to know what to do with them. Or, are you saying that they
are not representing
Is there a reason why you reversed the calculations for the slope at
line 374?
...jim
On 2/8/16 1:22 PM, Laurent Bourgès wrote:
Phil & Jim,
Please review a simple fix for a SEGV in Marlin renderer due to NaN
coordinates:
bug: https://bugs.openjdk.java.net/browse/JDK-81
In the test case, why are you using a log handler to check for a
particular exception? Shouldn't any exception logged be cause for a
test failure?
...jim
On 2/8/16 1:22 PM, Laurent Bourgès wrote:
Phil & Jim,
Please review a simple fix for a SEGV in Marlin renderer du
11 matches
Mail list logo
